You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/24 13:17:03 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #5679: [INLONG-5678][Manager] Provide source info for group status
woofyzhao opened a new pull request, #5679:
URL: https://github.com/apache/inlong/pull/5679
- Fixes #5678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5679: [INLONG-5678][Manager] Provide source info for group status
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5679:
URL: https://github.com/apache/inlong/pull/5679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5679: [INLONG-5678][Manager] Provide source info for group status
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5679:
URL: https://github.com/apache/inlong/pull/5679#discussion_r953802724
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/InlongGroupContext.java:
##########
@@ -75,6 +83,22 @@ public InlongGroupContext(InnerGroupContext groupContext) {
}
}
+ private List<StreamSource> getGroupSources() {
+ List<StreamSource> groupSources = Lists.newArrayList();
+ this.inlongStreamMap.values().forEach(inlongStream -> {
+ Map<String, StreamSource> sources = inlongStream.getSources();
+ if (MapUtils.isNotEmpty(sources)) {
+ for (Map.Entry<String, StreamSource> entry : sources.entrySet()) {
+ StreamSource source = entry.getValue();
+ if (source != null) {
+ sourcesInGroup.add(source);
Review Comment:
Where is the "sourcesInGroup" comes from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on a diff in pull request #5679: [INLONG-5678][Manager] Provide source info for group status
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #5679:
URL: https://github.com/apache/inlong/pull/5679#discussion_r953806623
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/InlongGroupContext.java:
##########
@@ -75,6 +83,22 @@ public InlongGroupContext(InnerGroupContext groupContext) {
}
}
+ private List<StreamSource> getGroupSources() {
+ List<StreamSource> groupSources = Lists.newArrayList();
+ this.inlongStreamMap.values().forEach(inlongStream -> {
+ Map<String, StreamSource> sources = inlongStream.getSources();
+ if (MapUtils.isNotEmpty(sources)) {
+ for (Map.Entry<String, StreamSource> entry : sources.entrySet()) {
+ StreamSource source = entry.getValue();
+ if (source != null) {
+ sourcesInGroup.add(source);
Review Comment:
Out of no where.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org