You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 22:21:17 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #11991: ARROW-13554: [C++] Remove deprecated Scanner::Scan

jonkeane commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r779905097



##########
File path: r/R/dataset-scan.R
##########
@@ -118,9 +113,6 @@ Scanner$create <- function(dataset,
   if (use_threads) {
     scanner_builder$UseThreads()
   }
-  if (use_async) {

Review comment:
       Yeah, we should warn about this. https://github.com/apache/arrow/blob/e64480db51fc9622d02613f3ec60bac34d765092/r/R/deprecated.R#L21 is an example of this.
   
   Something like:
   ```
   .Deprecated(msg = "Use of 'use_async' is deprecated")
   ```
   
   With a bit more explanation if we're now totally ignoring it, or what




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org