You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/02 14:33:30 UTC

[GitHub] [spark] gengliangwang commented on a diff in pull request #36702: [WIP][SPARK-39319][SQL] Make query context as part of SparkThrowable

gengliangwang commented on code in PR #36702:
URL: https://github.com/apache/spark/pull/36702#discussion_r888022982


##########
core/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -42,6 +42,8 @@ default String getSqlState() {
     return SparkThrowableHelper.getSqlState(this.getErrorClass());
   }
 
+  default QueryContext getQueryContext() { return null; }

Review Comment:
   OK, it requires efforts to refactor TreeNode.origin as `Seq[Origin]` from `Origin`. But let's make it an array in the interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org