You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "sergiimk (via GitHub)" <gi...@apache.org> on 2026/09/29 18:41:15 UTC
[I] Side effects from `serde_json/preserve_order` feature impact user applications [datafusion]
sergiimk opened a new issue, #25883:
URL: https://github.com/apache/datafusion/issues/25883
### Describe the bug
In `v55.0.0` the PR #21767 added the [`preserve_order` feature](https://github.com/apache/datafusion/blob/2cac713274496ba8ee08e58655e80f0d464f6d48/datafusion/physical-plan/Cargo.toml#L90) to `serde_json` dependency in `datafusion-physical-plan`.
This feature replaces `BTreeMap`-backed `serde_json::Value` with an `IndexMap` **globally**.
This is a major side-effect for applications embedding `datafusion`:
- It can affect performance
- It makes REST API return keys in different order
- It impacts many tests that may have depended on sorted keys
- It affects our cryptography that relies on stable sorted JSON representation.
Enabling this feature just doesn't seem like a choice that a library should make as its effects are disruptive and non-local.
### To Reproduce
-
### Expected behavior
I suspect `preserve_order` is only needed for testing and could be enabled in `dev-dependencies` without affecting applications that link `datafusion`. CC @adriangb
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Side effects from `serde_json/preserve_order` feature impact user applications [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on issue #25883:
URL: https://github.com/apache/datafusion/issues/25883#issuecomment-5917089800
I did link it there too! https://github.com/apache/datafusion/issues/25758#issuecomment-5904638560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Side effects from `serde_json/preserve_order` feature impact user applications [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on issue #25883:
URL: https://github.com/apache/datafusion/issues/25883#issuecomment-5904647371
Thanks for reporting @sergiimk and sorry for the issue, we should have caught this. There' a fix PR open and it's being tracked for the next patch release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Side effects from `serde_json/preserve_order` feature impact user applications [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb closed issue #25883: Side effects from `serde_json/preserve_order` feature impact user applications
URL: https://github.com/apache/datafusion/issues/25883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Side effects from `serde_json/preserve_order` feature impact user applications [datafusion]
Posted by "sergiimk (via GitHub)" <gi...@apache.org>.
sergiimk commented on issue #25883:
URL: https://github.com/apache/datafusion/issues/25883#issuecomment-5916304165
Really appreciate a quick turnaround @adriangb!
I see the issue is linked in [`56.0.0`](https://github.com/apache/datafusion/issues/24461) release. Any chance it can be included into the planned [`55.2.0`](https://github.com/apache/datafusion/issues/25758) instead? Would love to be able to finish upgrade to `55` instead of skipping one major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org