You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/01/09 22:14:37 UTC

Review Request 16763: SAMZA-126

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16763/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

skip broker fetches with empty fetch requests. sleep for a while in such a case.


Diffs
-----

  samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 124700e71f5a103c1f7db88c114d5861ebeb4d5c 
  samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 1012d58cc7b10e555074124c8ee79862537e1c75 
  samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e25cc4fa9e454d4131d115f980299f291d911466 

Diff: https://reviews.apache.org/r/16763/diff/


Testing
-------


Thanks,

Chris Riccomini

Re: Review Request 16763: SAMZA-126

Posted by Jakob Homan <jg...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16763/#review31463
-----------------------------------------------------------

Ship it!


- Jakob Homan


On Jan. 9, 2014, 1:14 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16763/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 1:14 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> skip broker fetches with empty fetch requests. sleep for a while in such a case.
> 
> 
> Diffs
> -----
> 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/BrokerProxy.scala 124700e71f5a103c1f7db88c114d5861ebeb4d5c 
>   samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemConsumerMetrics.scala 1012d58cc7b10e555074124c8ee79862537e1c75 
>   samza-kafka/src/test/scala/org/apache/samza/system/kafka/TestBrokerProxy.scala e25cc4fa9e454d4131d115f980299f291d911466 
> 
> Diff: https://reviews.apache.org/r/16763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>