[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1583: IGNITE-13022 Sql. Merge index conditions for the same field

["AMashenkov (via GitHub)" <gi...@apache.org>]

AMashenkov commented on code in PR #1583:
URL: https://github.com/apache/ignite-3/pull/1583#discussion_r1091662397


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java:
##########
@@ -757,7 +774,56 @@ public void testIndexedNullableFieldGreaterThanFilter() {
     }
 
     /**
-     * Test scan correclty handle 'nulls' when range condition is used.
+     * Test index search bounds merge.
+     */
+    @Test
+    public void testIndexBoundsMerge() {
+        assertQuery("SELECT id FROM Developer WHERE depId < 2 AND depId < ?")

Review Comment:
   I'd think we should check OR condition as well.
   AFAIK, OR condition may be rewritten with UNION (or JOIN?), but we expect the OR conditions will be merged and no rewrite happens.
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org