[GitHub] wujimin commented on a change in pull request #947: [SCB-837] make http2 production ready

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #947:  [SCB-837] make http2 production ready
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r224179606
 
 

 ##########
 File path: foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
 ##########
 @@ -77,8 +83,13 @@ public void dequeueRequest(DefaultClientEndpointMetric endpointMetric, Object ta
 
   @Override
   public void endpointConnected(DefaultClientEndpointMetric endpointMetric, DefaultHttpSocketMetric socketMetric) {
-    socketMetric.setEndpointMetric(endpointMetric);
-    endpointMetric.onConnect();
+    //only http1.1 will invoke this method, just make a check
+    if (endpointMetric != null) {
 
 Review comment:
   it's vertx bug: https://github.com/eclipse-vertx/vert.x/issues/2660
   please add comments, and remove the hack code after vertx fix the bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services