You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/28 06:57:54 UTC

[GitHub] john-bodley commented on a change in pull request #4500: [payload] Fixing regression introduced in ##4396

john-bodley commented on a change in pull request #4500: [payload] Fixing regression introduced in ##4396
URL: https://github.com/apache/incubator-superset/pull/4500#discussion_r171156482
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -327,8 +322,9 @@ def get_df_payload(self, query_obj=None):
         if query_obj and not is_loaded:
             try:
 
 Review comment:
   The try/except block may no longer be required per the PR description. This would make the `stacktrace` obsolete as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services