[GitHub] [druid] vogievetsky commented on a diff in pull request #13130: Web console: add append to existing callout

[GitBox <gi...@apache.org>]

vogievetsky commented on code in PR #13130:
URL: https://github.com/apache/druid/pull/13130#discussion_r976061312


##########
web-console/src/views/load-data-view/info-messages.tsx:
##########
@@ -216,3 +217,48 @@ export const SpecMessage = React.memo(function SpecMessage() {
     </FormGroup>
   );
 });
+
+export interface AppendToExistingIssueProps {
+  spec: Partial<IngestionSpec>;
+  onChangeSpec(newSpec: Partial<IngestionSpec>): void;
+}
+
+export const AppendToExistingIssue = React.memo(function AppendToExistingIssue(

Review Comment:
   Within the context of the console that is exactly what it is... the user has selected UI options that put the spec in the data loader into a state that can not be submitted. And this callout prompts the user to fix it. Note that I am not making a judgment on whether this behavior is an "issue in Druid" just that the data loader has an internal issue.
   
   The term "issue" is used in the same context all over the console codebase, for example https://github.com/apache/druid/blob/master/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx#L240 - this function will flag an "issue" if `spec.dataSchema.dataSource` is not set.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org