You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/05 19:06:46 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #12842: Build normal/backport providers based on correct list

potiuk commented on a change in pull request #12842:
URL: https://github.com/apache/airflow/pull/12842#discussion_r536869364



##########
File path: scripts/in_container/run_prepare_provider_packages.sh
##########
@@ -24,7 +24,7 @@ LIST_OF_DIRS_FILE=$(mktemp)
 
 cd "${AIRFLOW_SOURCES}/airflow/providers" || exit 1
 
-find . -type d | sed 's/.\///; s/\//\./g' | grep -E 'hooks|operators|sensors|secrets|utils' \
+find . -type d | sed 's!./!!; s!/!.!g' | grep -E 'hooks|operators|sensors|secrets|utils' \

Review comment:
       Here I removed "./" in front and then replaced  "/" with . to turn directories into providers "apache/hive" -> "apache.hive". That was the original meaning of this sed. I don't think the new sed does the same.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org