You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/28 01:05:28 UTC
Review Request 13002: Search frameworks & executors successively to save
concat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13002/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Search frameworks & executors successively to save concat
Array.concat creates a new Array, which in this case is used once to
find frameworks and executors and then thrown away. Instead the Arrays
can be searched successively in place without allocating more memory.
Original review: https://reviews.apache.org/r/12879/
Diffs
-----
src/webui/master/static/js/controllers.js b9099e012e7893bb1213ab81f4d57160678bf75e
Diff: https://reviews.apache.org/r/13002/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 13002: Search frameworks & executors successively to save
concat
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13002/#review24155
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 27, 2013, 11:06 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13002/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 11:06 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Search frameworks & executors successively to save concat
>
> Array.concat creates a new Array, which in this case is used once to
> find frameworks and executors and then thrown away. Instead the Arrays
> can be searched successively in place without allocating more memory.
>
> Original review: https://reviews.apache.org/r/12879/
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js b9099e012e7893bb1213ab81f4d57160678bf75e
>
> Diff: https://reviews.apache.org/r/13002/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 13002: Search frameworks & executors successively to save
concat
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13002/
-----------------------------------------------------------
(Updated July 27, 2013, 11:06 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Ben, this is the update to my commit submitted in review https://reviews.apache.org/r/12879/
Repository: mesos-git
Description
-------
Search frameworks & executors successively to save concat
Array.concat creates a new Array, which in this case is used once to
find frameworks and executors and then thrown away. Instead the Arrays
can be searched successively in place without allocating more memory.
Original review: https://reviews.apache.org/r/12879/
Diffs
-----
src/webui/master/static/js/controllers.js b9099e012e7893bb1213ab81f4d57160678bf75e
Diff: https://reviews.apache.org/r/13002/diff/
Testing
-------
Thanks,
Ross Allen