You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ro...@apache.org on 2015/02/20 13:49:27 UTC

svn commit: r1661113 - /sling/trunk/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/wizards/AbstractNewSlingApplicationWizard.java

Author: rombert
Date: Fri Feb 20 12:49:26 2015
New Revision: 1661113

URL: http://svn.apache.org/r1661113
Log:
SLING-4446 - AbstractNewSlingApplicationWizard publishes modules which
are not deployed

Modified:
    sling/trunk/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/wizards/AbstractNewSlingApplicationWizard.java

Modified: sling/trunk/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/wizards/AbstractNewSlingApplicationWizard.java
URL: http://svn.apache.org/viewvc/sling/trunk/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/wizards/AbstractNewSlingApplicationWizard.java?rev=1661113&r1=1661112&r2=1661113&view=diff
==============================================================================
--- sling/trunk/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/wizards/AbstractNewSlingApplicationWizard.java (original)
+++ sling/trunk/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/wizards/AbstractNewSlingApplicationWizard.java Fri Feb 20 12:49:26 2015
@@ -193,8 +193,16 @@ public abstract class AbstractNewSlingAp
         monitor.done();
     }
 
+    /**
+     * Extension method to allow subclasses to deploy and publish specific modules created by the wizard
+     * 
+     * <p>
+     * By default, all modules are deployed
+     * 
+     * @param module the module
+     * @return true is the module should be deployed, false otherwise
+     */
     protected boolean shouldDeploy(IModule module) {
-        // by default, deploy all applicable modules - subclasses may decide otherwise
         return true;
     }
 
@@ -209,7 +217,7 @@ public abstract class AbstractNewSlingAp
         List<IModule[]> modules = new ArrayList<IModule[]>();
         for (IProject project : createdProjects) {
             IModule module = ServerUtil.getModule(project);
-            if (module != null) {
+            if (module != null && shouldDeploy(module)) {
                 modules.add(new IModule[] { module });
             }
         }