You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <ja...@gmail.com> on 2005/06/20 02:07:13 UTC
[PATCH] Cleanup leftover Ruby test repositories
In some cases, the Ruby test suite leaves leftover test repositories
and working copies lying around in your build directory. This happens,
for example, when the test harness crashes.
These leftover test repositories can cause our test suite to not work.
They also take up disk space. So the following patch deletes the
leftover test repositories whenever the check-swig-rb or clean-swig-rb
targets are run.
[[[
Cleanup leftover Ruby test repositories before running the test
suite. Also cleanup leftover Ruby test repositories as part of the
clean-swig-rb target.
* Makefile.in
(clean-swig-rb-test-repos): Clean up leftover Ruby test repositories.
(clean-swig-rb): Add clean-swig-rb-test-repos as dependency.
(check-swig-rb): Add clean-swig-rb-test-repos as dependency.
]]]
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
Re: [PATCH] Cleanup leftover Ruby test repositories
Posted by Max Bowsher <ma...@ukf.net>.
David James wrote:
> On 6/19/05, Max Bowsher <ma...@ukf.net> wrote:
>> The comment:
>> +# Remove any leftover test repositories
>> is a little redundant, IMO.
> Good point -- I've removed it.
>
>> Apart from that, my only complaint is that the change cleans wcs as well
>> as repositories, and should be named appropriately - just drop the
>> "-repos" part from the make rule name, and tweak the log message.
> Done. That looks much better!
>
>> Then, if it works fine for you, I think it is sufficiently localised to be
>> considered part of your commit domain, despite touching a buildsystem file.
> I was wondering about that -- thanks for the explanation! I'm glad I
> sent this patch through the list first because your feedback was very
> helpful.
You're welcome.
Regarding commit domains, there is no solid set of rules spelled out anywhere, so it's pretty much a case of following the spirit of
the law rather than the letter, because the letter of the law never got written!
We have a fairly easy-going attitude to access control in this project :-)
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Cleanup leftover Ruby test repositories
Posted by David James <ja...@gmail.com>.
On 6/19/05, Max Bowsher <ma...@ukf.net> wrote:
> The comment:
> +# Remove any leftover test repositories
> is a little redundant, IMO.
Good point -- I've removed it.
> Apart from that, my only complaint is that the change cleans wcs as well as repositories, and should be named appropriately - just
> drop the "-repos" part from the make rule name, and tweak the log message.
Done. That looks much better!
> Then, if it works fine for you, I think it is sufficiently localised to be considered part of your commit domain, despite touching a
> buildsystem file.
I was wondering about that -- thanks for the explanation! I'm glad I
sent this patch through the list first because your feedback was very
helpful.
Committed in r15112.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Cleanup leftover Ruby test repositories
Posted by Max Bowsher <ma...@ukf.net>.
David James wrote:
> In some cases, the Ruby test suite leaves leftover test repositories
> and working copies lying around in your build directory. This happens,
> for example, when the test harness crashes.
>
> These leftover test repositories can cause our test suite to not work.
> They also take up disk space. So the following patch deletes the
> leftover test repositories whenever the check-swig-rb or clean-swig-rb
> targets are run.
>
> [[[
> Cleanup leftover Ruby test repositories before running the test
> suite. Also cleanup leftover Ruby test repositories as part of the
> clean-swig-rb target.
>
> * Makefile.in
> (clean-swig-rb-test-repos): Clean up leftover Ruby test repositories.
> (clean-swig-rb): Add clean-swig-rb-test-repos as dependency.
> (check-swig-rb): Add clean-swig-rb-test-repos as dependency.
>
> ]]]
The comment:
+# Remove any leftover test repositories
is a little redundant, IMO.
Apart from that, my only complaint is that the change cleans wcs as well as repositories, and should be named appropriately - just
drop the "-repos" part from the make rule name, and tweak the log message.
Then, if it works fine for you, I think it is sufficiently localised to be considered part of your commit domain, despite touching a
buildsystem file.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org