You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Todd Currie (JIRA)" <ji...@codehaus.org> on 2014/04/01 00:38:59 UTC

[jira] (SCM-745) Perforce Blame Result Parsing Error

Todd Currie created SCM-745:
-------------------------------

             Summary: Perforce Blame Result Parsing Error
                 Key: SCM-745
                 URL: https://jira.codehaus.org/browse/SCM-745
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-perforce
    Affects Versions: 1.9, 1.8.1
            Reporter: Todd Currie


The regex for the parsing of the author information from the command line results is incorrect.  It is overly greedy and is consuming additional characters depending upon the change comments entered by the author.

org.apache.maven.scm.provider.perforce.command.blame.PerforceFilelogConsumer

39c39
<     private static final String LINE_PATTERN = "#(\\d+).*on (.*) by (.*)@";
---
>     private static final String LINE_PATTERN = "#(\\d+).*?on (.*?) by (.*?)@";


Example of failure:
Changelist:	 624405
Date:	 2013/07/19 14:05
Client:	 ws_advertising
User:	 mccabej
Description:	
Fix retry order so that the @Retryable proxy always executes first.

Resulting Author is "mccabej@ws_advertising (ktext) 'Fix retry order so that the "



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)