You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/15 07:38:05 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
BiteTheDDDDt opened a new pull request, #15104:
URL: https://github.com/apache/doris/pull/15104
# Proposed changes
1. disable ABSL_BTREE_ENABLE_GENERATIONS
2. use CMAKE_BUILD_TYPE to replace o3
fix https://github.com/apache/doris/pull/15002
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/doris/pull/15104#issuecomment-1352692479
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/doris/pull/15104#issuecomment-1352903863
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15104:
URL: https://github.com/apache/doris/pull/15104#issuecomment-1352754767
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.45 seconds
load time: 467 seconds
storage size: 17123356818 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221215090702_clickbench_pr_63848.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #15104:
URL: https://github.com/apache/doris/pull/15104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/doris/pull/15104#issuecomment-1352669326
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3702048687") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -975,11 +975,11 @@
cd "${TP_SOURCE_DIR}/${ABSEIL_SOURCE}"
LDFLAGS="-L${TP_LIB_DIR}" \
- "${CMAKE_CMD}" -B "${BUILD_DIR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
- -DABSL_ENABLE_INSTALL=ON \
- -DBUILD_DEPS=ON \
- -DCMAKE_BUILD_TYPE=Release \
- -DBUILD_SHARED_LIBS=OFF \
+ "${CMAKE_CMD}" -B "${BUILD_DIR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
+ -DABSL_ENABLE_INSTALL=ON \
+ -DBUILD_DEPS=ON \
+ -DCMAKE_BUILD_TYPE=Release \
+ -DBUILD_SHARED_LIBS=OFF
cmake --build "${BUILD_DIR}" -j "${PARALLEL}"
cmake --install "${BUILD_DIR}" --prefix "${TP_INSTALL_DIR}"
@@ -996,12 +996,12 @@
rm -rf CMakeCache.txt CMakeFiles/
LDFLAGS="-L${TP_LIB_DIR}" \
- ${CMAKE_CMD} -G "${GENERATOR}" -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
- -DCMAKE_PREFIX_PATH="${TP_INSTALL_DIR}" \
- -DBUILD_SHARED_LIBS=OFF \
- -DWITH_GFLAGS=ON \
- -DCMAKE_BUILD_TYPE=Release \
- -DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}" ..
+ ${CMAKE_CMD} -G "${GENERATOR}" -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
+ -DCMAKE_PREFIX_PATH="${TP_INSTALL_DIR}" \
+ -DBUILD_SHARED_LIBS=OFF \
+ -DWITH_GFLAGS=ON \
+ -DCMAKE_BUILD_TYPE=Release \
+ -DCMAKE_LIBRARY_PATH="${TP_INSTALL_DIR}" ..
"${BUILD_SYSTEM}" -j "${PARALLEL}"
"${BUILD_SYSTEM}" install
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/doris/pull/15104#issuecomment-1352674644
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15104: [Chore](s2geo) disable ABSL_BTREE_ENABLE_GENERATIONS and use CMAKE_BUILD_TYPE to rep…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15104:
URL: https://github.com/apache/doris/pull/15104#issuecomment-1352674668
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org