You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/20 05:25:13 UTC

[GitHub] [ozone] adoroszlai commented on a diff in pull request #3763: HDDS-7237. Update datanode's configuration variable names FAILED_DATA_VOLUMES_TOLERATED, FAILED_METADATA_VOLUMES_TOLERATED with their string values

adoroszlai commented on code in PR #3763:
URL: https://github.com/apache/ozone/pull/3763#discussion_r974897382


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -42,9 +42,9 @@ public class DatanodeConfiguration {
       "hdds.datanode.container.delete.threads.max";
   static final String PERIODIC_DISK_CHECK_INTERVAL_MINUTES_KEY =
       "hdds.datanode.periodic.disk.check.interval.minutes";
-  public static final String FAILED_DATA_VOLUMES_TOLERATED_KEY =

Review Comment:
   @DaveTeng0 I agree with @kaijchen, I think this change is unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org