You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/03/24 03:01:56 UTC

[Bug 121946] New: [UCB] css::ucb::XWebDAVCommandEnvironment - use constants to identify WebDAV/HTTP methods

https://issues.apache.org/ooo/show_bug.cgi?id=121946

            Bug ID: 121946
        Issue Type: DEFECT
           Summary: [UCB] css::ucb::XWebDAVCommandEnvironment - use
                    constants to identify WebDAV/HTTP methods
    Classification: Unclassified
           Product: App Dev
           Version: AOO 3.4.1
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: api
          Assignee: issues@openoffice.apache.org
          Reporter: arielch@apache.org
                CC: issues@openoffice.apache.org

css::ucb::XWebDAVCommandEnvironment::getUserRequestHeaders() uses a string to
identify the WebDAV/HTTP method.

It would be better to use a constant instead of a string.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121946] [UCB] css::ucb::XWebDAVCommandEnvironment - use enums to identify WebDAV/HTTP methods

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121946

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[UCB]                       |[UCB]
                   |css::ucb::XWebDAVCommandEnv |css::ucb::XWebDAVCommandEnv
                   |ironment - use constants to |ironment - use enums to
                   |identify WebDAV/HTTP        |identify WebDAV/HTTP
                   |methods                     |methods

--- Comment #3 from Ariel Constenla-Haile <ar...@apache.org> ---
Adapting the title, I had to use enums, DELETE is a macro in winnt.h :

#define DELETE (0x00010000L)

I could have worked around this in the source file using ifdefs and undef, but
it would have been a breaker if anyone ever uses the constant in the future.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121946] [UCB] css::ucb::XWebDAVCommandEnvironment - use constants to identify WebDAV/HTTP methods

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121946

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
           Assignee|issues@openoffice.apache.or |arielch@apache.org
                   |g                           |
   Target Milestone|---                         |AOO 4.0

--- Comment #2 from Ariel Constenla-Haile <ar...@apache.org> ---
Fixed on trunk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 121946] [UCB] css::ucb::XWebDAVCommandEnvironment - use constants to identify WebDAV/HTTP methods

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121946

--- Comment #1 from SVN Robot <sv...@dev.null.org> ---
"arielch" committed SVN revision 1460363 into trunk:
i121946 - Use enums to identify WebDAV/HTTP methods

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.