You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2014/10/26 10:48:53 UTC
Review Request 27206: Create Kerberos Service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 26, 2014, 2:32 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml, line 134
> > <https://reviews.apache.org/r/27206/diff/1/?file=733504#file733504line134>
> >
> > Is kdc-conf intentionally skipped as a configuration-dependency ? This will not show restart indicator against kdc on we-ui when any configuration is changed in kdc-conf file.
That was accidentally left out... fixing and resubmitting a patch. Thanks.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58568
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58568
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml
<https://reviews.apache.org/r/27206/#comment99626>
Is kdc-conf intentionally skipped as a configuration-dependency ? This will not show restart indicator against kdc on we-ui when any configuration is changed in kdc-conf file.
- Jaimin Jetly
On Oct. 26, 2014, 9:48 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2014, 9:48 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review62136
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Nov. 14, 2014, 10:14 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 10:14 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java 61a2fb9
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14
>
> Running tests for stack:2.2 service:KERBEROS
> test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 0.151s
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:44 min
> [INFO] Finished at: 2014-11-13T12:28:08+00:00
> [INFO] Final Memory: 41M/412M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 19, 2014, 9:04 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
Changes
-------
* Fixed append comments to read properly
* Fixed issue where splitting domains variable was not splitting on ,
* Fixed issue where white-space in *-keytab variables were causing the Service Check command to fail.
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml 44cce66
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml ff8b9fb
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml 4f3ddbd
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py 664de5b
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 41628b9
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14
Running tests for stack:2.2 service:KERBEROS
test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
----------------------------------------------------------------------
Ran 8 tests in 0.151s
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:44 min
[INFO] Finished at: 2014-11-13T12:28:08+00:00
[INFO] Final Memory: 41M/412M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 5:14 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
Changes
-------
Changed template property name from `conf_template` to `content`
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/Role.java 61a2fb9
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14
Running tests for stack:2.2 service:KERBEROS
test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
----------------------------------------------------------------------
Ran 8 tests in 0.151s
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:44 min
[INFO] Finished at: 2014-11-13T12:28:08+00:00
[INFO] Final Memory: 41M/412M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Nov. 13, 2014, 4:11 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, lines 177-181
> > <https://reviews.apache.org/r/27206/diff/7/?file=762180#file762180line177>
> >
> > -norandkey is not supported with the older version of the kerberos. Is code taking care of this ?
`-norandkey` would only be used if no administrator credentials were supplied triggering `kadmin.local` to be used rather than `kadmin`. The case would only successfully occur if a managed KDC was being used, and we know this is a newever version of the KDC implementation. On top of that, these peice of code would rarely be executed since most keytabs would be generated on the Ambari Server, not on the agent side. This code would only get executed in the case where a managed KDC was being installed and we needed to create the administrative credentials.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review61316
-----------------------------------------------------------
On Nov. 13, 2014, 8:29 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 8:29 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14
>
> Running tests for stack:2.2 service:KERBEROS
> test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 0.151s
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:44 min
> [INFO] Finished at: 2014-11-13T12:28:08+00:00
> [INFO] Final Memory: 41M/412M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review61316
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml
<https://reviews.apache.org/r/27206/#comment102868>
Please name this property as content to remain in consistent with the other template/file properties exposed by the ambari (*-env, *-log4j,pig-properties)
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml
<https://reviews.apache.org/r/27206/#comment102869>
Please name this property as content to remain in consistent with the other template/file properties exposed by the ambari (*-env, *-log4j,pig-properties)
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml
<https://reviews.apache.org/r/27206/#comment102870>
Please name this property as content to remain in consistent with the other template/file properties exposed by the ambari (*-env, *-log4j,pig-properties)
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py
<https://reviews.apache.org/r/27206/#comment102871>
-norandkey is not supported with the older version of the kerberos. Is code taking care of this ?
- Jaimin Jetly
On Nov. 13, 2014, 1:29 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 1:29 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14
>
> Running tests for stack:2.2 service:KERBEROS
> test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
> test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
> test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 0.151s
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:44 min
> [INFO] Finished at: 2014-11-13T12:28:08+00:00
> [INFO] Final Memory: 41M/412M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 13, 2014, 8:29 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
Changes
-------
Updated `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest` due to changes in `org.apache.ambari.server.api.services.AmbariMetaInfo`
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing (updated)
-------
Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14
Running tests for stack:2.2 service:KERBEROS
test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) ... ok
test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok
test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok
test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok
test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) ... ok
test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok
test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok
test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok
----------------------------------------------------------------------
Ran 8 tests in 0.151s
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:44 min
[INFO] Finished at: 2014-11-13T12:28:08+00:00
[INFO] Final Memory: 41M/412M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 9:53 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, Robert Nettleton, and Yusaku Sako.
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 9, 2014, 7:24 p.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Changes
-------
Added ability to test kinit using either the smoke test user credentials or the supplied test user credentials. The preference is to use the smoke test user, but if details or the keytab file are not available, the supplied test credentials (from the krb-conf configuration set) will be used.
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 8, 2014, 6:37 p.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Changes
-------
Updates to support new requirements:
* No longer (officially) supporting managed KDC server
* Configuration files are built using Jinja templates
* Better support for wizard UI
* Service check / smoke test is available - attempts to kinit with test principal and either password or keytab
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 4:27 p.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/realms-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review59570
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Oct. 30, 2014, 10:09 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 10:09 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/realms-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Oct. 30, 2014, 10:09 p.m.)
Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Changes
-------
* Updated to allow for new realms configuration scheme (move to realms-conf configuration type/block)
* Fixes for Ubuntu platform
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/realms-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Oct. 30, 2014, 1:18 p.m.)
Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Changes
-------
Updated to address noted issues:
* moved all configuration and parameter parsing to params.py
* added python unit tests
* ensured service works on multiple platforms - Centos/Red Hat and SLES
* allow for reconfiguration before start
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas
Re: Review Request 27206: Create Kerberos Service
Posted by Yusaku Sako <yu...@hortonworks.com>.
> On Oct. 28, 2014, 8:27 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml, line 98
> > <https://reviews.apache.org/r/27206/diff/2/?file=734106#file734106line98>
> >
> > This does not scope for debian OS.
> > Isn't kerberos automation epic going to support redhat5, redhat6, suse11 and ununtu12 ?
>
> Robert Levas wrote:
> I expect that this service should work with support redhat5, redhat6, suse11, ununtu12, and eventually windows.
We might need to specify Ubuntu-specific package names: https://help.ubuntu.com/community/Kerberos
- Yusaku
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58858
-----------------------------------------------------------
On Oct. 27, 2014, 2:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 2:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 28, 2014, 4:27 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml, line 98
> > <https://reviews.apache.org/r/27206/diff/2/?file=734106#file734106line98>
> >
> > This does not scope for debian OS.
> > Isn't kerberos automation epic going to support redhat5, redhat6, suse11 and ununtu12 ?
>
> Robert Levas wrote:
> I expect that this service should work with support redhat5, redhat6, suse11, ununtu12, and eventually windows.
>
> Yusaku Sako wrote:
> We might need to specify Ubuntu-specific package names: https://help.ubuntu.com/community/Kerberos
Indeed... I have most of this set up already. I am just having issues figuring how how to install Ambari on Ubuntu - any suggestions?
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58858
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 28, 2014, 4:27 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml, line 98
> > <https://reviews.apache.org/r/27206/diff/2/?file=734106#file734106line98>
> >
> > This does not scope for debian OS.
> > Isn't kerberos automation epic going to support redhat5, redhat6, suse11 and ununtu12 ?
I expect that this service should work with support redhat5, redhat6, suse11, ununtu12, and eventually windows.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58858
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58858
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml
<https://reviews.apache.org/r/27206/#comment100012>
This does not scope for debian OS.
Isn't kerberos automation epic going to support redhat5, redhat6, suse11 and ununtu12 ?
- Jaimin Jetly
On Oct. 27, 2014, 2:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 2:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, lines 30-36
> > <https://reviews.apache.org/r/27206/diff/2/?file=734108#file734108line30>
> >
> > There seems to be a lot of these - they're typically pre-determined in a params.py file. Can these not be done like with the other components?
>
> Robert Levas wrote:
> My way _felt_ safter, but I can try to recode to use the param.py file method.
How set are you on the params.py file? I am not sure what it is buying me.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58645
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Nate Cole <nc...@hortonworks.com>.
> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, lines 30-36
> > <https://reviews.apache.org/r/27206/diff/2/?file=734108#file734108line30>
> >
> > There seems to be a lot of these - they're typically pre-determined in a params.py file. Can these not be done like with the other components?
>
> Robert Levas wrote:
> My way _felt_ safter, but I can try to recode to use the param.py file method.
>
> Robert Levas wrote:
> How set are you on the params.py file? I am not sure what it is buying me.
a) it's consistent with every other service and b) defining a class full of @staticmethod buys you nothing. Better off using an plain kerberos_util.py or something instead.
It's going to be a bit trickier writing tests against static methods of a class than plain "regular" methods in a non-class module.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58645
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml, lines 18-23
> > <https://reviews.apache.org/r/27206/diff/2/?file=734106#file734106line18>
> >
> > Should be 2 space indent
Oops... forgot to configure IntelliJ XML formatting.. :(
> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py, line 26
> > <https://reviews.apache.org/r/27206/diff/2/?file=734107#file734107line26>
> >
> > Does the client require krb5-server?
The client does not require the server, hence the exclustion of the server-specific packages.
> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, lines 30-36
> > <https://reviews.apache.org/r/27206/diff/2/?file=734108#file734108line30>
> >
> > There seems to be a lot of these - they're typically pre-determined in a params.py file. Can these not be done like with the other components?
My way _felt_ safter, but I can try to recode to use the param.py file method.
> On Oct. 27, 2014, 2:32 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, lines 255-269
> > <https://reviews.apache.org/r/27206/diff/2/?file=734108#file734108line255>
> >
> > Can this be abstracted out via params.py?
I'll look into this.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58645
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58645
-----------------------------------------------------------
Python should get unit tests too. Also, a lot of file-writing operations have already been written, can any of those be used?
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml
<https://reviews.apache.org/r/27206/#comment99703>
Should be 2 space indent
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py
<https://reviews.apache.org/r/27206/#comment99704>
Does the client require krb5-server?
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py
<https://reviews.apache.org/r/27206/#comment99708>
There seems to be a lot of these - they're typically pre-determined in a params.py file. Can these not be done like with the other components?
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py
<https://reviews.apache.org/r/27206/#comment99709>
python doc goes in the method itself
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py
<https://reviews.apache.org/r/27206/#comment99711>
Can this be abstracted out via params.py?
- Nate Cole
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
> On Oct. 29, 2014, 8:33 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py, line 73
> > <https://reviews.apache.org/r/27206/diff/2/?file=734109#file734109line73>
> >
> > start command on KDC service component should also call self.configure(env) function to support reconfiguration scenario.
> >
> > Otherwise once kerberos is installed and after that if krb5-conf or kdc-conf configurations are changed in the Ambari and kerberos is restarted, the config change will never occur on the KDC host in the actual files
>
> Robert Levas wrote:
> Is this typical behavior or just special for the Kerberos service?
This is a typical behavior for any service in the stack. All services support reconfiguration. So when a start task for a service component is received at the agent, first service's configuration are updated and then service component is started. If we browse through python script of any existing service's master/slave component in the stack, it's start function will be calling configure function.
- Jaimin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review59041
-----------------------------------------------------------
On Oct. 27, 2014, 2:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 2:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 29, 2014, 4:33 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py, line 73
> > <https://reviews.apache.org/r/27206/diff/2/?file=734109#file734109line73>
> >
> > start command on KDC service component should also call self.configure(env) function to support reconfiguration scenario.
> >
> > Otherwise once kerberos is installed and after that if krb5-conf or kdc-conf configurations are changed in the Ambari and kerberos is restarted, the config change will never occur on the KDC host in the actual files
>
> Robert Levas wrote:
> Is this typical behavior or just special for the Kerberos service?
>
> Jaimin Jetly wrote:
> This is a typical behavior for any service in the stack. All services support reconfiguration. So when a start task for a service component is received at the agent, first service's configuration are updated and then service component is started. If we browse through python script of any existing service's master/slave component in the stack, it's start function will be calling configure function.
I updated the service definition to support this and all my tests appeared to work fine. However, changing the configration of the Kerberos infrastrucutre is dangerous since existing keytabs may become invalid. For example if the realm name(s) are changed.
As of my lastest patch, I think that I have covered all open issues.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review59041
-----------------------------------------------------------
On Oct. 30, 2014, 10:09 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 10:09 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/realms-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 29, 2014, 4:33 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py, line 73
> > <https://reviews.apache.org/r/27206/diff/2/?file=734109#file734109line73>
> >
> > start command on KDC service component should also call self.configure(env) function to support reconfiguration scenario.
> >
> > Otherwise once kerberos is installed and after that if krb5-conf or kdc-conf configurations are changed in the Ambari and kerberos is restarted, the config change will never occur on the KDC host in the actual files
Is this typical behavior or just special for the Kerberos service?
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review59041
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review59041
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py
<https://reviews.apache.org/r/27206/#comment100323>
start command on KDC service component should also call self.configure(env) function to support reconfiguration scenario.
Otherwise once kerberos is installed and after that if krb5-conf or kdc-conf configurations are changed in the Ambari and kerberos is restarted, the config change will never occur on the KDC host in the actual files
- Jaimin Jetly
On Oct. 27, 2014, 2:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 2:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
> On Oct. 27, 2014, 12:57 p.m., Jaimin Jetly wrote:
> > Ship It!
Thanks.. but I am going to make another patch for this. I currenty each KDC is listed as kdc-<ident>, I want to make this less confusing and list them as realm-<ident> since the kdc-conf block is for the kdc.conf file and the kdc/realm-<ident> blocks lists the realms or KDCs for the cluster.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58624
-----------------------------------------------------------
On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 10:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/#review58624
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Oct. 27, 2014, 2:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27206/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 2:37 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
>
>
> Bugs: AMBARI-7448
> https://issues.apache.org/jira/browse/AMBARI-7448
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
>
> See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27206/diff/
>
>
> Testing
> -------
>
> Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27206: Create Kerberos Service
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27206/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 10:37 a.m.)
Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku Sako.
Changes
-------
Added configuration dependency on kdc-conf in metainfo.xml
Bugs: AMBARI-7448
https://issues.apache.org/jira/browse/AMBARI-7448
Repository: ambari
Description
-------
Create a service to manage the (optional) Kerberos server (managed KDC) and client components in the HDP 2.2 stack.
See [Ambari Cluster Kerberization Technical Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) for more information.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/27206/diff/
Testing
-------
Added new unit test - `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest`
Thanks,
Robert Levas