[jira] Commented: (HBASE-2792) Create a better way to chain log cleaners

["Li Chongxin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891177#action_12891177 ] 

Li Chongxin commented on HBASE-2792:
------------------------------------

here is some discussion about this issue in private mail:

bq. My idea is to replace the LogCleanerDelegate in OldLogsCleaner with a list of LogCleanerDelegate. A new LogCleanerDelegate is added to the list if it is required. Then the log file is checked against each LogCleanerDelegate in the list. It is deletable only if all the LogCleanerDelegate pass. For later dev who wants to provide a new LogCleanerDelegate, all he has to do is to implement the LogCleanerDelegate and add it to the list.

>From Jean-Daniel's reply:
bq. I think what you described sounds good, but I would add the requirement that anybody should be able to add their own implementations without changing the code (the new class would need to be on HBase's classpath). I think this could be done via the configuration file, like a comma separated list of fully qualified class names.

> Create a better way to chain log cleaners
> -----------------------------------------
>
>                 Key: HBASE-2792
>                 URL: https://issues.apache.org/jira/browse/HBASE-2792
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Li Chongxin
>             Fix For: 0.90.0
>
>
> From Stack's review of HBASE-2223:
> {quote}
> Why this implementation have to know about other implementations?  Can't we do a chain of decision classes? Any class can say no?  As soon as any decision class says no, we exit the chain.... So in this case, first on the chain would be the ttl decision... then would be this one... and third would be the snapshotting decision. You don't have to do the chain as part of this patch but please open an issue to implement.
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.