You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sarutak <gi...@git.apache.org> on 2014/11/05 20:49:55 UTC
[GitHub] incubator-flink pull request: [FLINK-1217] Keepalive option should...
GitHub user sarutak opened a pull request:
https://github.com/apache/incubator-flink/pull/182
[FLINK-1217] Keepalive option should be set to sockets in Client and Server
Sockets in Client and Server is not set keepalive option.
I think we should set keepalive option to socket to detect hang or network disconnection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarutak/incubator-flink socket-keepalive
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit e1b12d60b27de3b039d38b549dede28ac83b7659
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date: 2014-11-05T19:45:26Z
Added keepalive option to sockets in Client and Server
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1217] Keepalive option should...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak commented on the pull request:
https://github.com/apache/incubator-flink/pull/182#issuecomment-62382371
Actually, I have never hit issues caused by not setting keepalive. It's just usual practice of socket programming but ping can work well. I'll close this PR for now and if I hit actual problem, I reopen this PR or open new PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1217] Keepalive option should...
Posted by sarutak <gi...@git.apache.org>.
Github user sarutak closed the pull request at:
https://github.com/apache/incubator-flink/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1217] Keepalive option should...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/182#issuecomment-62363477
@sarutak: Have you experienced an issue that you've fixed with this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-1217] Keepalive option should...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/182#issuecomment-62036482
I am not entirely sure about the implications. Probably okay, though the RPC does its own Pings anyways.
Have you tried that out and noticed a difference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---