You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2014/10/28 00:30:36 UTC
Review Request 27254: Alerts UI: create routes for new alerts pages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27254/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.
Repository: ambari
Description
-------
In this jira, need to make sure all new alerts pages are there with blank content (or some test content), also the URLs are correct.
(For how new pages look like, take a look at the mock ups in https://hortonworks.jira.com/browse/RMP-1745.)
Here are the new alerts pages we need to add :
* Alerts summary page: a new tab 'Alerts' on the top-nav bar will trigger this page. So we will have 'Dashboard', 'Services', 'Hosts', 'Alerts', 'Admin', 'Views' ... on the top nav bar after adding 'Alerts'. The URL should be: http://<hostname>:8080/#/main/alerts
* Alert definition page. The URL should be: http://<hostname>:8080/#/main/alerts/<definition_name>
* Host details > Alerts tab. The URL should be: http://<hostname>:8080/#/main/hosts/<hostname>/summary
Diffs
-----
ambari-web/app/config.js f7171bf
ambari-web/app/messages.js 99a429c
ambari-web/app/routes/main.js bfdfc8c
ambari-web/app/templates/main/alerts.hbs PRE-CREATION
ambari-web/app/templates/main/host/alerts.hbs PRE-CREATION
ambari-web/app/views.js 1970248
ambari-web/app/views/main/alerts.js PRE-CREATION
ambari-web/app/views/main/host/alerts.js PRE-CREATION
ambari-web/app/views/main/host/menu.js 0cd19b3
ambari-web/app/views/main/menu.js 6c68f53
Diff: https://reviews.apache.org/r/27254/diff/
Testing
-------
Thanks,
Xi Wang
Re: Review Request 27254: Alerts UI: create routes for new alerts
pages
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27254/#review58734
-----------------------------------------------------------
1. Can you fill out the corresponding AMBARI JIRA ID in the Review?
2. Can you remove the link to Hortonworks JIRA? It's not publicly accessible. The mocks should be on an Apache Ambari JIRA, so please provide an appropriate link.
3. > Host details > Alerts tab. The URL should be: http://<hostname>:8080/#/main/hosts/<hostname>/summary
Do you mean .../<hostname>/alerts?
- Yusaku Sako
On Oct. 27, 2014, 11:30 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27254/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 11:30 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this jira, need to make sure all new alerts pages are there with blank content (or some test content), also the URLs are correct.
>
> (For how new pages look like, take a look at the mock ups in https://hortonworks.jira.com/browse/RMP-1745.)
>
> Here are the new alerts pages we need to add :
>
> * Alerts summary page: a new tab 'Alerts' on the top-nav bar will trigger this page. So we will have 'Dashboard', 'Services', 'Hosts', 'Alerts', 'Admin', 'Views' ... on the top nav bar after adding 'Alerts'. The URL should be: http://<hostname>:8080/#/main/alerts
>
> * Alert definition page. The URL should be: http://<hostname>:8080/#/main/alerts/<definition_name>
> * Host details > Alerts tab. The URL should be: http://<hostname>:8080/#/main/hosts/<hostname>/summary
>
>
> Diffs
> -----
>
> ambari-web/app/config.js f7171bf
> ambari-web/app/messages.js 99a429c
> ambari-web/app/routes/main.js bfdfc8c
> ambari-web/app/templates/main/alerts.hbs PRE-CREATION
> ambari-web/app/templates/main/host/alerts.hbs PRE-CREATION
> ambari-web/app/views.js 1970248
> ambari-web/app/views/main/alerts.js PRE-CREATION
> ambari-web/app/views/main/host/alerts.js PRE-CREATION
> ambari-web/app/views/main/host/menu.js 0cd19b3
> ambari-web/app/views/main/menu.js 6c68f53
>
> Diff: https://reviews.apache.org/r/27254/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 27254: Alerts UI: create routes for new alerts
pages
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27254/#review58974
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 28, 2014, 12:47 до полудня, Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27254/
> -----------------------------------------------------------
>
> (Updated Жов. 28, 2014, 12:47 до полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.
>
>
> Bugs: AMBARI-7992
> https://issues.apache.org/jira/browse/AMBARI-7992
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In this jira, need to make sure all new alerts pages are there with blank content (or some test content), also the URLs are correct.
>
>
> Here are the new alerts pages we need to add :
>
> * Alerts summary page: a new tab 'Alerts' on the top-nav bar will trigger this page. So we will have 'Dashboard', 'Services', 'Hosts', 'Alerts', 'Admin', 'Views' ... on the top nav bar after adding 'Alerts'. The URL should be: http://<hostname>:8080/#/main/alerts
>
> * Host details > Alerts tab. The URL should be: http://<hostname>:8080/#/main/hosts/<hostname>/alerts
>
>
> Diffs
> -----
>
> ambari-web/app/config.js f7171bf
> ambari-web/app/messages.js 99a429c
> ambari-web/app/routes/main.js bfdfc8c
> ambari-web/app/templates/main/alerts.hbs PRE-CREATION
> ambari-web/app/templates/main/host/alerts.hbs PRE-CREATION
> ambari-web/app/views.js 1970248
> ambari-web/app/views/main/alerts.js PRE-CREATION
> ambari-web/app/views/main/host/alerts.js PRE-CREATION
> ambari-web/app/views/main/host/menu.js 0cd19b3
> ambari-web/app/views/main/menu.js 6c68f53
>
> Diff: https://reviews.apache.org/r/27254/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 27254: Alerts UI: create routes for new alerts
pages
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27254/
-----------------------------------------------------------
(Updated Oct. 27, 2014, 5:47 p.m.)
Review request for Ambari, Aleksandr Kovalenko and Srimanth Gunturi.
Bugs: AMBARI-7992
https://issues.apache.org/jira/browse/AMBARI-7992
Repository: ambari
Description (updated)
-------
In this jira, need to make sure all new alerts pages are there with blank content (or some test content), also the URLs are correct.
Here are the new alerts pages we need to add :
* Alerts summary page: a new tab 'Alerts' on the top-nav bar will trigger this page. So we will have 'Dashboard', 'Services', 'Hosts', 'Alerts', 'Admin', 'Views' ... on the top nav bar after adding 'Alerts'. The URL should be: http://<hostname>:8080/#/main/alerts
* Host details > Alerts tab. The URL should be: http://<hostname>:8080/#/main/hosts/<hostname>/alerts
Diffs
-----
ambari-web/app/config.js f7171bf
ambari-web/app/messages.js 99a429c
ambari-web/app/routes/main.js bfdfc8c
ambari-web/app/templates/main/alerts.hbs PRE-CREATION
ambari-web/app/templates/main/host/alerts.hbs PRE-CREATION
ambari-web/app/views.js 1970248
ambari-web/app/views/main/alerts.js PRE-CREATION
ambari-web/app/views/main/host/alerts.js PRE-CREATION
ambari-web/app/views/main/host/menu.js 0cd19b3
ambari-web/app/views/main/menu.js 6c68f53
Diff: https://reviews.apache.org/r/27254/diff/
Testing
-------
Thanks,
Xi Wang