[GitHub] nifi-minifi-cpp pull request #435: MINIFICPP-665: Add reference checks for s...

[phrocker <gi...@git.apache.org>]

GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/435

    MINIFICPP-665: Add reference checks for self

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-665

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #435
    
----
commit 6bf85fd9f4f188cfa0fcbc95fe60f53644b24bca
Author: Marc Parisi <ph...@...>
Date:   2018-11-11T02:06:08Z

    MINIFICPP-665: Add reference checks for self

----


---

[GitHub] nifi-minifi-cpp pull request #435: MINIFICPP-665: Add reference checks for s...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/435


---

[GitHub] nifi-minifi-cpp pull request #435: MINIFICPP-665: Add reference checks for s...

[arpadboda <gi...@git.apache.org>]

Github user arpadboda commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/435#discussion_r232960242
  
    --- Diff: libminifi/src/io/BaseStream.cpp ---
    @@ -143,15 +147,19 @@ int BaseStream::read(uint8_t *value, int len) {
      * @param buflen
      */
     int BaseStream::readData(std::vector<uint8_t> &buf, int buflen) {
    -  return Serializable::read(&buf[0], buflen, reinterpret_cast<DataStream*>(composable_stream_));
    +  return Serializable::read(&buf[0], buflen, composable_stream_);
     }
     /**
      * Reads data and places it into buf
      * @param buf buffer in which we extract data
      * @param buflen
      */
     int BaseStream::readData(uint8_t *buf, int buflen) {
    -  return Serializable::read(buf, buflen, reinterpret_cast<DataStream*>(composable_stream_));
    +  if (composable_stream_ == this) {
    --- End diff --
    
    Likely?


---

[GitHub] nifi-minifi-cpp issue #435: MINIFICPP-665: Add reference checks for self

[arpadboda <gi...@git.apache.org>]

Github user arpadboda commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/435
  
    The implementation is fine, I wonder if:
    -This all could be done using template member functions
    -We could add some more details to commit msg


---

[GitHub] nifi-minifi-cpp issue #435: MINIFICPP-665: Add reference checks for self

[phrocker <gi...@git.apache.org>]

Github user phrocker commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/435
  
    @arpadboda yah we can compare templates. But we lose the ability to change source of streams. Was on fence about that 


---