You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/05/18 15:03:26 UTC
[tomcat] 02/02: Silence false positive IDE warning
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 99e36dc2c38518f7eeef2295852836aa88df5f1e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Sat May 18 16:02:48 2019 +0100
Silence false positive IDE warning
---
java/org/apache/tomcat/util/net/AprEndpoint.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/java/org/apache/tomcat/util/net/AprEndpoint.java b/java/org/apache/tomcat/util/net/AprEndpoint.java
index d61febc..f5fa038 100644
--- a/java/org/apache/tomcat/util/net/AprEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AprEndpoint.java
@@ -2814,6 +2814,7 @@ public class AprEndpoint extends AbstractEndpoint<Long,Long> implements SNICallB
nBytes = flushBytes;
flushBytes = 0;
} else {
+ @SuppressWarnings("null") // Not possible
int remaining = buffer.remaining();
write(block == BlockingMode.BLOCK, buffer);
nBytes = remaining - buffer.remaining();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] 02/02: Silence false positive IDE warning
Posted by Rémy Maucherat <re...@apache.org>.
On Sat, May 18, 2019 at 5:03 PM <ma...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
> commit 99e36dc2c38518f7eeef2295852836aa88df5f1e
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Sat May 18 16:02:48 2019 +0100
>
> Silence false positive IDE warning
>
Indeed. I thought about improving this further, but it works fine and
nobody is actually going to use it, so it will stay as is.
Rémy
> ---
> java/org/apache/tomcat/util/net/AprEndpoint.java | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/java/org/apache/tomcat/util/net/AprEndpoint.java
> b/java/org/apache/tomcat/util/net/AprEndpoint.java
> index d61febc..f5fa038 100644
> --- a/java/org/apache/tomcat/util/net/AprEndpoint.java
> +++ b/java/org/apache/tomcat/util/net/AprEndpoint.java
> @@ -2814,6 +2814,7 @@ public class AprEndpoint extends
> AbstractEndpoint<Long,Long> implements SNICallB
> nBytes = flushBytes;
> flushBytes = 0;
> } else {
> + @SuppressWarnings("null") // Not
> possible
> int remaining =
> buffer.remaining();
> write(block ==
> BlockingMode.BLOCK, buffer);
> nBytes = remaining -
> buffer.remaining();
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>