You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/23 16:16:31 UTC

[GitHub] [pulsar] lhotari commented on a diff in pull request #17241: [managed-ledger] prevent sending duplicate reads to BK/offloaders

lhotari commented on code in PR #17241:
URL: https://github.com/apache/pulsar/pull/17241#discussion_r952838957


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/cache/RangeEntryCacheImpl.java:
##########
@@ -256,6 +271,77 @@ public void asyncReadEntry(ReadHandle lh, long firstEntry, long lastEntry, boole
         }
     }
 
+    @AllArgsConstructor
+    private static final class ReadEntriesCallbackWithContext {
+        ReadEntriesCallback callback;
+        Object ctx;

Review Comment:
   make fields `final`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org