[GitHub] timifasubaa commented on a change in pull request #5281: [SQL lab] Fixed limit issue

[GitBox <gi...@apache.org>]

timifasubaa commented on a change in pull request #5281: [SQL lab] Fixed limit issue
URL: https://github.com/apache/incubator-superset/pull/5281#discussion_r197907059
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -127,8 +126,7 @@ def get_query_without_limit(cls, sql):
                 (?ix)        # case insensitive, verbose
                 \s+          # whitespace
                 LIMIT\s+\d+  # LIMIT $ROWS
-                ;?           # optional semi-colon
-                (\s|;)*$     # remove trailing spaces tabs or semicolons
+                (\s|;|.)*$   # remove the reset of the chars
 
 Review comment:
   How about we selected everything after the limit and also passed that along to the caller so the caller can do something lie "{before_limit} {new_limit} {after_limit}" That should fix problem 3 (adding the things after the limit). And to do that, we will just change this line to to `(.*$)` and pass the regex results. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org