You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/05 17:05:53 UTC
[GitHub] [beam] lostluck opened a new pull request, #23990: [Go] Pipeline Resource Hints
lostluck opened a new pull request, #23990:
URL: https://github.com/apache/beam/pull/23990
Does the v0 pass to add resource hints as mentioned in #23893.
* Adds resource package to manage hints, while enabling custom hints.
* Adds --resource_hints flag with the same behavior as Beam Java and Python (tolerant of "unknown" hints)
* Sets the hints on the default environment fields.
* Minor improvements to test coverage.
Validated that runners do respect the hints if desired, by having Dataflow Prime use a higher minimum bound of ram than default.
At this stage a user can use the flag from the command line, or manually set the flag to programatically change the pipeline level hints. However, this doesn't enable custom types that aren't in the "beam:resources:" URN namespace at this time. Once scoped resource hints are added, and multiple Go environments supported, the user will be able to derive custom hints as needed on whatever scoped side mechanism exists.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304659887
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015984189
##########
sdks/go/pkg/beam/options/jobopts/options.go:
##########
@@ -169,3 +179,49 @@ func GetExperiments() []string {
}
return strings.Split(*Experiments, ",")
}
+
+// GetPipelineResourceHints parses known standard hints and returns the flag set hints for the pipeline.
+// In case of duplicate hint URNs, the last value specified will be used.
+func GetPipelineResourceHints() resource.Hints {
+ hints := make([]resource.Hint, 0, len(ResourceHints))
+ for _, hint := range ResourceHints {
+ name, val, ok := strings.Cut(hint, "=")
+ if !ok {
+ panic(fmt.Sprintf("unparsable resource hint: %q", hint))
+ }
+ var h resource.Hint
+ switch name {
+ case "min_ram":
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1016739936
##########
sdks/go/pkg/beam/options/resource/hint.go:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package resource supports Beam resource hints to specify scoped hints or annotations
+// to pipelines.
+//
+// See https://beam.apache.org/documentation/runtime/resource-hints/ for more information.
+package resource
+
+import (
+ "bytes"
+ "fmt"
+ "strconv"
+
+ "github.com/dustin/go-humanize"
+)
+
+// Hints contains a list of hints for a given scope.
+type Hints struct {
+ h map[string]Hint
+}
+
+// MergeWithOuter produces a new list of Hints from this Hints, and the Hints from the outer scope.
Review Comment:
Cool, as long as we're consistent that's good with me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304757696
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304763665
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304716647
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015991231
##########
sdks/go/pkg/beam/options/jobopts/options.go:
##########
@@ -169,3 +179,49 @@ func GetExperiments() []string {
}
return strings.Split(*Experiments, ",")
}
+
+// GetPipelineResourceHints parses known standard hints and returns the flag set hints for the pipeline.
+// In case of duplicate hint URNs, the last value specified will be used.
+func GetPipelineResourceHints() resource.Hints {
+ hints := make([]resource.Hint, 0, len(ResourceHints))
+ for _, hint := range ResourceHints {
+ name, val, ok := strings.Cut(hint, "=")
+ if !ok {
+ panic(fmt.Sprintf("unparsable resource hint: %q", hint))
+ }
+ var h resource.Hint
+ switch name {
+ case "min_ram":
Review Comment:
To be clear here, it seems reasonable to maintain the correct semantics SDK side if we're able to, and it's not hard to add them to the switch statement. Also updated the test cases to ensure they're overriding as described in the flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304591628
# [Codecov](https://codecov.io/gh/apache/beam/pull/23990?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23990](https://codecov.io/gh/apache/beam/pull/23990?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a14aef) into [master](https://codecov.io/gh/apache/beam/commit/68aee2f78898505f890a34a862a37e9dd25c9ac9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68aee2f) will **increase** coverage by `0.03%`.
> The diff coverage is `88.33%`.
```diff
@@ Coverage Diff @@
## master #23990 +/- ##
==========================================
+ Coverage 73.84% 73.88% +0.03%
==========================================
Files 707 708 +1
Lines 95746 95888 +142
==========================================
+ Hits 70708 70846 +138
- Misses 23721 23724 +3
- Partials 1317 1318 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `51.28% <88.33%> (+0.22%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/options.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvb3B0aW9ucy5nbw==) | `82.22% <ø> (ø)` | |
| [sdks/go/pkg/beam/options/jobopts/stringSlice.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL2pvYm9wdHMvc3RyaW5nU2xpY2UuZ28=) | `71.42% <ø> (ø)` | |
| [sdks/go/pkg/beam/runners/dataflow/dataflow.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93Lmdv) | `58.79% <0.00%> (-0.99%)` | :arrow_down: |
| [sdks/go/pkg/beam/options/jobopts/options.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL2pvYm9wdHMvb3B0aW9ucy5nbw==) | `93.18% <81.81%> (+5.90%)` | :arrow_up: |
| [sdks/go/pkg/beam/options/resource/hint.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9vcHRpb25zL3Jlc291cmNlL2hpbnQuZ28=) | `94.80% <94.80%> (ø)` | |
| [sdks/go/pkg/beam/core/runtime/graphx/translate.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L3RyYW5zbGF0ZS5nbw==) | `38.35% <100.00%> (+0.27%)` | :arrow_up: |
| [...s/go/pkg/beam/core/runtime/graphx/schema/schema.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZ3JhcGh4L3NjaGVtYS9zY2hlbWEuZ28=) | `65.94% <0.00%> (-0.06%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/metrics/dumper.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL21ldHJpY3MvZHVtcGVyLmdv) | `53.96% <0.00%> (+4.76%)` | :arrow_up: |
| [sdks/go/pkg/beam/register/iter.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9yZWdpc3Rlci9pdGVyLmdv) | `72.97% <0.00%> (+5.75%)` | :arrow_up: |
| [sdks/go/pkg/beam/register/emitter.go](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9yZWdpc3Rlci9lbWl0dGVyLmdv) | `54.05% <0.00%> (+6.36%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/beam/pull/23990/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304618519
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304637273
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304726972
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304828058
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304774903
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304815345
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304847198
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015865539
##########
sdks/go/pkg/beam/options/jobopts/options.go:
##########
@@ -45,6 +46,12 @@ func init() {
"have no more than 1 override applied to it. If multiple "+
"overrides match a container image it is arbitrary which "+
"will be applied.")
+ flag.Var(&ResourceHints,
+ "resource_hints",
+ "Set whole pipeline level resource hints, accepting values of the format '<urn>=<value>'. "+
+ "Supports 'min_ram' and 'accelerator' hints. "+
Review Comment:
Optional opinionated feedback - IMO its not a great idea to specify the full set of acceptable values like that if the accepted values are liable to change without updating the code since its really easy for them to get out of date.
I'd personally prefer specifying these as example options
##########
sdks/go/pkg/beam/options/jobopts/options.go:
##########
@@ -169,3 +179,49 @@ func GetExperiments() []string {
}
return strings.Split(*Experiments, ",")
}
+
+// GetPipelineResourceHints parses known standard hints and returns the flag set hints for the pipeline.
+// In case of duplicate hint URNs, the last value specified will be used.
+func GetPipelineResourceHints() resource.Hints {
+ hints := make([]resource.Hint, 0, len(ResourceHints))
+ for _, hint := range ResourceHints {
+ name, val, ok := strings.Cut(hint, "=")
+ if !ok {
+ panic(fmt.Sprintf("unparsable resource hint: %q", hint))
+ }
+ var h resource.Hint
+ switch name {
+ case "min_ram":
Review Comment:
Should we also check for equality to the fully specified payload (`beam:resources:min_ram_bytes:v1`)? Same thing with accelerator
##########
sdks/go/pkg/beam/options/resource/hint.go:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package resource supports Beam resource hints to specify scoped hints or annotations
+// to pipelines.
+//
+// See https://beam.apache.org/documentation/runtime/resource-hints/ for more information.
+package resource
+
+import (
+ "bytes"
+ "fmt"
+ "strconv"
+
+ "github.com/dustin/go-humanize"
+)
+
+// Hints contains a list of hints for a given scope.
+type Hints struct {
+ h map[string]Hint
+}
+
+// MergeWithOuter produces a new list of Hints from this Hints, and the Hints from the outer scope.
Review Comment:
2 thoughts:
1) Could you specify the merge strategy? Looks like it is hint dependent, specifying that would be enough
2) Does I don't quite get the naming here - why is this MergeWithOuter and the analogous hint level operation is MergeWith? Personally, my vote would just be for Merge, but staying consistent is the more important piece.
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -1122,7 +1126,12 @@ const defaultEnvId = "go"
func (m *marshaller) addDefaultEnv() string {
if _, exists := m.environments[defaultEnvId]; !exists {
- m.environments[defaultEnvId] = m.opt.Environment
+ env := proto.Clone(m.opt.Environment).(*pipepb.Environment)
+ // Add the pipeline level resource hints here for now.
+ // TODO(https://github.com/apache/beam/issues/23893) move to a better place for
+ // scoped hints in next pass, which affect number of environments set by Go pipelines.
+ env.ResourceHints = m.opt.PipelineResourceHints.Payloads()
Review Comment:
I think `m.opt.PipelineResourceHints` is not guaranteed to be non-nil (e.g. on the direct runner I don't think this will ever get set). It would be good to do a nil check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1306090828
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015987946
##########
sdks/go/pkg/beam/core/runtime/graphx/translate.go:
##########
@@ -1122,7 +1126,12 @@ const defaultEnvId = "go"
func (m *marshaller) addDefaultEnv() string {
if _, exists := m.environments[defaultEnvId]; !exists {
- m.environments[defaultEnvId] = m.opt.Environment
+ env := proto.Clone(m.opt.Environment).(*pipepb.Environment)
+ // Add the pipeline level resource hints here for now.
+ // TODO(https://github.com/apache/beam/issues/23893) move to a better place for
+ // scoped hints in next pass, which affect number of environments set by Go pipelines.
+ env.ResourceHints = m.opt.PipelineResourceHints.Payloads()
Review Comment:
It isn't guaranteed to be non-nil, but it is implemented to be valid as a zero value. It simply returns an empty map for `Payloads`.
That is, `var Foo Hints` is valid, it's simply an immutable empty value. There is a test to ensure that the zero value Hints is safe for all its methods.
One must use `resource.NewHints` to create a new grouping of hints to ensure these semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304737968
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304842671
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304650193
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304645981
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304676945
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304680901
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304821938
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304710734
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304742864
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015986231
##########
sdks/go/pkg/beam/options/resource/hint.go:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package resource supports Beam resource hints to specify scoped hints or annotations
+// to pipelines.
+//
+// See https://beam.apache.org/documentation/runtime/resource-hints/ for more information.
+package resource
+
+import (
+ "bytes"
+ "fmt"
+ "strconv"
+
+ "github.com/dustin/go-humanize"
+)
+
+// Hints contains a list of hints for a given scope.
+type Hints struct {
+ h map[string]Hint
+}
+
+// MergeWithOuter produces a new list of Hints from this Hints, and the Hints from the outer scope.
Review Comment:
1. It is hint dependant, but there is a default approach. Both mentioned.
2. Switched to MergeWithOuter for the Hint as well. Because the merge is order dependant (outer scope vs inner scope) the order needs to be clear. Merge implies order independance. By default, an "inner" hint takes precedence. So the naming makes it clear how it's supposed to be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1306354742
Updates made, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304723644
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304798828
stop reviewer notifications
On Sun, Nov 6, 2022, 5:11 AM github-actions[bot] ***@***.***>
wrote:
> Assigning reviewers. If you would like to opt out of this review, comment assign
> to next reviewer:
>
> R: @damccorm <https://github.com/damccorm> for label go.
>
> Available commands:
>
> - stop reviewer notifications - opt out of the automated review tooling
> - remind me after tests pass - tag the comment author after tests pass
> - waiting on author - shift the attention set back to the author (any
> comment or push by the author will return the attention set to the
> reviewers)
>
> The PR bot will only process comments in the main thread (not review
> comments).
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/23990#issuecomment-1304798627>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADKDOFPMFFXAWME5P4MI4RTWG6VANANCNFSM6AAAAAARYAHLZA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304845566
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #23990:
URL: https://github.com/apache/beam/pull/23990#discussion_r1015982803
##########
sdks/go/pkg/beam/options/jobopts/options.go:
##########
@@ -45,6 +46,12 @@ func init() {
"have no more than 1 override applied to it. If multiple "+
"overrides match a container image it is arbitrary which "+
"will be applied.")
+ flag.Var(&ResourceHints,
+ "resource_hints",
+ "Set whole pipeline level resource hints, accepting values of the format '<urn>=<value>'. "+
+ "Supports 'min_ram' and 'accelerator' hints. "+
Review Comment:
Good call. Agreed. This was written before I learned that there's a "break glass" with default URN semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304666232
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304708652
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304628137
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304706419
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304798627
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #23990:
URL: https://github.com/apache/beam/pull/23990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304809410
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304730541
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304752228
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304591006
Run Go Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304747556
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304692115
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304733742
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304713725
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304779514
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304701438
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304769774
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304793826
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304785976
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304841219
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304613424
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304834183
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304848928
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304653961
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304641474
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23990: [Go] Pipeline Resource Hints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23990:
URL: https://github.com/apache/beam/pull/23990#issuecomment-1304803819
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org