[GitHub] spark pull request #13061: [SPARK-14279] [Build] Pick the spark version from...

[jodersky <gi...@git.apache.org>]

Github user jodersky commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13061#discussion_r65464743
  
    --- Diff: core/src/main/scala/org/apache/spark/package.scala ---
    @@ -41,7 +41,53 @@ package org.apache
      * level interfaces. These are subject to changes or removal in minor releases.
      */
     
    +import java.util.Properties
    +
     package object spark {
    -  // For package docs only
    -  val SPARK_VERSION = "2.0.0-SNAPSHOT"
    +
    +  private object SparkBuildInfo {
    +    val resourceStream = Thread.currentThread().getContextClassLoader.
    +      getResourceAsStream("spark-version-info.properties")
    +
    +    val (
    +      spark_version: String,
    --- End diff --
    
    is this purposefully using underscores? `sparkVersion` is consistent with the general style


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org