You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/09/14 17:28:45 UTC
[PR] [SPARK-59500][K8S] Promote `KubernetesExecutorConf` to `DeveloperApi` [spark]
dongjoon-hyun opened a new pull request, #58783:
URL: https://github.com/apache/spark/pull/58783
### What changes were proposed in this pull request?
This PR aims to promote `KubernetesExecutorConf` to `DeveloperApi` and `Unstable` with a Java-friendly constructor, symmetric to `KubernetesDriverConf`.
### Why are the changes needed?
`KubernetesDriverConf` was promoted to `DeveloperApi` at Apache Spark 4.0.0 via SPARK-48121, and its Java-friendly constructor was added at 4.3.0 via SPARK-58333.
https://github.com/apache/spark/blob/389de941f002a5c92e22dc3ed0f65af602a174db/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala#L88-L96
`KubernetesExecutorConf` is still `private[spark]` although it has been exposed to users since 3.3.0 via `KubernetesExecutorCustomFeatureConfigStep.init(config: KubernetesExecutorConf)`. This PR promotes it in the same way to provide a Java-friendly `DeveloperApi` for external projects such as the Apache Spark Kubernetes Operator.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs with a newly added test case in `KubernetesConfSuite`.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59500][K8S] Promote `KubernetesExecutorConf` to `DeveloperApi` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58783: [SPARK-59500][K8S] Promote `KubernetesExecutorConf` to `DeveloperApi`
URL: https://github.com/apache/spark/pull/58783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59500][K8S] Promote `KubernetesExecutorConf` to `DeveloperApi` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58783:
URL: https://github.com/apache/spark/pull/58783#issuecomment-5668688506
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/eb4c1880f6347e51b0f485ee12e6c1f7087deb9f
- merged into branch-4.x https://github.com/apache/spark/commit/fa05c685cd86ade20285e337844819413e9ede06
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59500][K8S] Promote `KubernetesExecutorConf` to `DeveloperApi` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58783:
URL: https://github.com/apache/spark/pull/58783#issuecomment-5668648743
Could you review this PR too, @peter-toth ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59500][K8S] Promote `KubernetesExecutorConf` to `DeveloperApi` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58783:
URL: https://github.com/apache/spark/pull/58783#issuecomment-5668677383
Thank you always, @peter-toth !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org