You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2015/04/07 03:38:31 UTC
[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/429
[THRIFT-3086] fix a few minor valgrind identified issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift bugfix/THRIFT-3086-minor-valgrind-issues
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #429
----
commit 86889762402795b78e4c1c9381d5b699e74c5fae
Author: Jim King <ji...@simplivity.com>
Date: 2015-04-07T01:38:06Z
[THRIFT-3086] fix a few minor valgrind identified issues
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/429#issuecomment-90742753
@bufferoverflow Thanks for the heads up, if that is in the process documentation for submitting requests I missed it. I'll remove the brackets in my pull requests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...
Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/429#issuecomment-90697644
@jeking3 please do not use square brackets [] around the thrift issue identifer, this will be removed when I use git am toi apply the patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 closed the pull request at:
https://github.com/apache/thrift/pull/429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: [THRIFT-3086] fix a few minor valgrind identi...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the pull request:
https://github.com/apache/thrift/pull/429#issuecomment-91282080
The code has been merged so I am closing the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---