You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2023/03/07 07:38:59 UTC

[GitHub] [iceberg] nastra commented on a diff in pull request #7003: AWS: bump aws sdk version to 2.20.16

nastra commented on code in PR #7003:
URL: https://github.com/apache/iceberg/pull/7003#discussion_r1127462562


##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3SignRequestParser.java:
##########
@@ -126,7 +126,7 @@ public void roundTripSerde() {
                     "Content-Type",
                     Arrays.asList("application/json"),
                     "User-Agent",
-                    Arrays.asList("aws-sdk-java/2.17.257", "Linux/5.4.0-126")))
+                    Arrays.asList("aws-sdk-java/2.20.16", "Linux/5.4.0-126")))

Review Comment:
   updating this isn't really necessary. When I wrote the test I just wanted to have some real headers :)
   
   We can also just update this to have some random number if that's confusing people.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org