You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/17 02:10:55 UTC

[GitHub] [iotdb] jun0315 opened a new pull request #4411: [IOTDB-2022]SessionDataSet implements AutoCloseable

jun0315 opened a new pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411


   see https://issues.apache.org/jira/browse/IOTDB-2022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#issuecomment-971145680


   
   [![Coverage Status](https://coveralls.io/builds/44321489/badge)](https://coveralls.io/builds/44321489)
   
   Coverage increased (+0.02%) to 66.589% when pulling **49f39601e9c07f105ef6d34f5d858b8e60807448 on jun0315:session_data_set_auto_auto_closable** into **44fccddf553e80c29e055cb9a1d59630762917bf on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#issuecomment-971145680


   
   [![Coverage Status](https://coveralls.io/builds/44321512/badge)](https://coveralls.io/builds/44321512)
   
   Coverage decreased (-0.007%) to 66.567% when pulling **49f39601e9c07f105ef6d34f5d858b8e60807448 on jun0315:session_data_set_auto_auto_closable** into **44fccddf553e80c29e055cb9a1d59630762917bf on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#issuecomment-971145680


   
   [![Coverage Status](https://coveralls.io/builds/44321830/badge)](https://coveralls.io/builds/44321830)
   
   Coverage increased (+0.02%) to 66.589% when pulling **49f39601e9c07f105ef6d34f5d858b8e60807448 on jun0315:session_data_set_auto_auto_closable** into **44fccddf553e80c29e055cb9a1d59630762917bf on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#issuecomment-971145680


   
   [![Coverage Status](https://coveralls.io/builds/44323443/badge)](https://coveralls.io/builds/44323443)
   
   Coverage decreased (-0.04%) to 66.532% when pulling **da0a512c1bfc36dcaff13e623dd98ee0899f2b54 on jun0315:session_data_set_auto_auto_closable** into **44fccddf553e80c29e055cb9a1d59630762917bf on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4411: [IOTDB-2022]SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#discussion_r750845475



##########
File path: session/src/main/java/org/apache/iotdb/session/SessionDataSet.java
##########
@@ -196,6 +196,15 @@ public DataIterator iterator() {
     return new DataIterator();
   }
 
+  @Override
+  public void close() throws IoTDBConnectionException, StatementExecutionException {
+    try {
+      ioTDBRpcDataSet.close();
+    } catch (TException e) {
+      throw new IoTDBConnectionException(e.getMessage());
+    }

Review comment:
       ```suggestion
       closeOperationHandle()
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#issuecomment-971145680


   
   [![Coverage Status](https://coveralls.io/builds/44321611/badge)](https://coveralls.io/builds/44321611)
   
   Coverage increased (+0.03%) to 66.608% when pulling **49f39601e9c07f105ef6d34f5d858b8e60807448 on jun0315:session_data_set_auto_auto_closable** into **44fccddf553e80c29e055cb9a1d59630762917bf on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#issuecomment-971145680


   
   [![Coverage Status](https://coveralls.io/builds/44323235/badge)](https://coveralls.io/builds/44323235)
   
   Coverage decreased (-0.05%) to 66.523% when pulling **da0a512c1bfc36dcaff13e623dd98ee0899f2b54 on jun0315:session_data_set_auto_auto_closable** into **44fccddf553e80c29e055cb9a1d59630762917bf on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu merged pull request #4411: [IOTDB-2022] SessionDataSet implements AutoCloseable

Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org