You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/03/05 20:49:42 UTC

Re: Use ProxyUriManager in CssRequestRewriter (issue224093)

LGTM


http://codereview.appspot.com/224093/diff/2001/2003
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java
(right):

http://codereview.appspot.com/224093/diff/2001/2003#newcode211
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java:211:
if (config.shouldRewriteURL(uri.getResource().toString())) {
Since you check for shouldRewriteUrl in line 67, do you really need to
check again? one of the check is redundant.

http://codereview.appspot.com/224093/show

Re: Use ProxyUriManager in CssRequestRewriter (issue224093)

Posted by John Hjelmstad <jo...@gmail.com>.

Good call, fixed, thx!

On Fri, Mar 5, 2010 at 11:49 AM, <zh...@gmail.com> wrote:

> LGTM
>
>
> http://codereview.appspot.com/224093/diff/2001/2003
> File
>
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java
> (right):
>
> http://codereview.appspot.com/224093/diff/2001/2003#newcode211
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssRequestRewriter.java:211:
> if (config.shouldRewriteURL(uri.getResource().toString())) {
> Since you check for shouldRewriteUrl in line 67, do you really need to
> check again? one of the check is redundant.
>
>
> http://codereview.appspot.com/224093/show
>