You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/17 10:33:47 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #36901: [MINOR] Update known_translations
MaxGekk opened a new pull request, #36901:
URL: https://github.com/apache/spark/pull/36901
### What changes were proposed in this pull request?
In the PR, I propose to update the file `dev/create-release/known_translations` by new contributors to 3.3.0
### Why are the changes needed?
While preparing the list of contributors to 3.3.0 in the PR https://github.com/apache/spark-website/pull/397, I have found that some of contributors are not in the file `known_translations`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #36901:
URL: https://github.com/apache/spark/pull/36901#discussion_r900021947
##########
dev/create-release/known_translations:
##########
@@ -416,3 +416,94 @@ zsxwing - Shixiong Zhu
zuotingbing - Tingbing Zuo
zuxqoj - Shekhar Bansal
zzcclp - Zhichao Zhang
+Alfonso - Alfonso Buono
Review Comment:
The file is an output of `translate-contributors.py` which just adds new items to the end of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Byron commented on pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
Byron commented on PR #36901:
URL: https://github.com/apache/spark/pull/36901#issuecomment-1158744385
Please remove me, must be a mixup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36901:
URL: https://github.com/apache/spark/pull/36901#discussion_r900000485
##########
dev/create-release/known_translations:
##########
@@ -416,3 +416,94 @@ zsxwing - Shixiong Zhu
zuotingbing - Tingbing Zuo
zuxqoj - Shekhar Bansal
zzcclp - Zhichao Zhang
+Alfonso - Alfonso Buono
+Angerszhuuuu - Angerszhuuuu
+BOOTMGR - Harsh Panchal
+BelodengKlaus - Klaus Belodeng
+Byron - Byron
+Cedric-Magnan - Cedric-Magnan
+Daniel-Davies - Daniel Davies
+Darek - Darek Zoń
+Geek - Geek
+IonutBoicuAms - Ionut Boicu
+Jie - Jie
+Leona - Leona
+PengLei - Peng Lei
+Qian.Sun - Qian Sun
+RabbidHY - RabbidHY
+RoryQi - Rory Qi
+SaurabhChawla - Saurabh Chawla
+Shockang - Shockang
+TongWeii - Tong Weii
+Utkarsh - Utkarsh Srivastava
+Wang - Wang
+YangJie - Yang Jie
+Yikf - Yi Kaifei
+Yimin - Li Yimin
+alexander_holmes - Alexander Holmes
+beobest2 - Hyunwoo Park
+bjornjorgensen - Bjørn Jørgensen
+chenzhx - Zhixiong Chen
+copperybean - copperybean
+daugraph - daugraph
+dchvn - dchvn
+dgd-contributor - dgd-contributor
+dgd_contributor - dgd_contributor
+dohongdayi - dohongdayi
+erenavsarogullari - Eren Avsarogullari
+fhygh - fhygh
+flynn - Flynn
+gaoyajun02 - gaoyajun02
+gengjiaan - gengjiaan
+herman - Herman Geuvers
+hi-zir - hi-zir
+huangmaoyang2 - huangmaoyang2
+huaxingao - Huaxin Gao
+hujiahua - hujiahua
+jackierwzhang - jackierwzhang
+jackylee-ch - Jacky Lee
+jiaoqb - Qingbo Jiao
+jinhai - Jin Hai
+khalidmammadov - Khalid Mammadov
+kuwii - kuwii
+leesf - leesf
+mans2singh - mans2singh
+mcdull-zhang - mcdull-zhang
+michaelzhang-db - michaelzhang-db
+minyyy - minyyy
+nyingping - Nie Yingping
+pralabhkumar - Pralabh Kumar
+remykarem - Remy
+sandeepvinayak - Sandeep Pal
+senthilkumarb - Senthil Kumar Bhaskaran
+skhandrikagmail - skhandrikagmail
+sperlingxx - Alfred Xu
+sudoliyang - Liyang Zhang
+sweisdb - sweisdb
+sychen - Sung-Yu Chen
+tan.vu - Tan Vu
+tanel.kiis@gmail.com - tanel.kiis@gmail.com
+tenglei - tenglei
+tianhanhu - tianhanhu
+tianlzhang - tianlzhang
+timothy65535 - timothy65535
+tooptoop4 - tooptoop4
+vadim - Vadim Patsalo
+w00507315 - w00507315
+wangguangxin.cn - wangguangxin.cn
+wangshengjie3 - wangshengjie3
+wayneguow - Wei Guo
+wooplevip - wooplevip
+wuyi - Wu Yi
+xiepengjie - xiepengjie
+xuyu - xuyu
+yangjie01 - yangjie01
+yaohua - yaohua
+yi.wu - yi.wu
Review Comment:
This should be a map between GitHub ID and actual name IIRC.
@yi.wu seems invalid GitHub ID at least. We will have to remove these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36901: [MINOR] Update known_translations
URL: https://github.com/apache/spark/pull/36901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36901:
URL: https://github.com/apache/spark/pull/36901#issuecomment-1158742478
Please, review the mapping below. If you don't agree, please, let me know:
@Alfonso - Alfonso Buono
@Angerszhuuuu - Angerszhuuuu
@BOOTMGR - Harsh Panchal
@BelodengKlaus - Klaus Belodeng
@Byron - Byron
@Cedric-Magnan - Cedric-Magnan
@Daniel-Davies - Daniel Davies
@Darek - Darek Zoń
@Geek - Geek
@IonutBoicuAms - Ionut Boicu
@Jie - Jie
@Leona - Leona
@PengLei - Peng Lei
@Qian.Sun - Qian Sun
@RabbidHY - RabbidHY
@RoryQi - Rory Qi
@SaurabhChawla - Saurabh Chawla
@Shockang - Shockang
@TongWeii - Tong Weii
@Utkarsh - Utkarsh Srivastava
@Wang - Wang
@YangJie - Yang Jie
@Yikf - Yi Kaifei
@Yimin - Li Yimin
@alexander_holmes - Alexander Holmes
@beobest2 - Hyunwoo Park
@bjornjorgensen - Bjørn Jørgensen
@chenzhx - Zhixiong Chen
@copperybean - copperybean
@daugraph - daugraph
@dchvn - dchvn
@dgd-contributor - dgd-contributor
@dgd_contributor - dgd_contributor
@dohongdayi - dohongdayi
@erenavsarogullari - Eren Avsarogullari
@fhygh - fhygh
@flynn - Flynn
@gaoyajun02 - gaoyajun02
@gengjiaan - gengjiaan
@herman - Herman Geuvers
@hi-zir - hi-zir
@huangmaoyang2 - huangmaoyang2
@huaxingao - Huaxin Gao
@hujiahua - hujiahua
@jackierwzhang - jackierwzhang
@jackylee-ch - Jacky Lee
@jiaoqb - Qingbo Jiao
@jinhai - Jin Hai
@khalidmammadov - Khalid Mammadov
@kuwii - kuwii
@leesf - leesf
@mans2singh - mans2singh
@mcdull-zhang - mcdull-zhang
@michaelzhang-db - michaelzhang-db
@minyyy - minyyy
@nyingping - Nie Yingping
@pralabhkumar - Pralabh Kumar
@remykarem - Remy
@sandeepvinayak - Sandeep Pal
@senthilkumarb - Senthil Kumar Bhaskaran
@skhandrikagmail - skhandrikagmail
@sperlingxx - Alfred Xu
@sudoliyang - Liyang Zhang
@sweisdb - sweisdb
@sychen - Sung-Yu Chen
@tan.vu - Tan Vu
@tanel.kiis@gmail.com - tanel.kiis@gmail.com
@tenglei - tenglei
@tianhanhu - tianhanhu
@tianlzhang - tianlzhang
@timothy65535 - timothy65535
@tooptoop4 - tooptoop4
@vadim - Vadim Patsalo
@w00507315 - w00507315
@wangguangxin.cn - wangguangxin.cn
@wangshengjie3 - wangshengjie3
@wayneguow - Wei Guo
@wooplevip - wooplevip
@wuyi - Wu Yi
@xiepengjie - xiepengjie
@xuyu - xuyu
@yangjie01 - yangjie01
@yaohua - yaohua
@yi.wu - yi.wu
@yikaifei - yikaifei
@yoda-mon - yoda-mon
@zhangxudong1 - zhangxudong1
@zhoubin11 - zhoubin11
@zhouyifan279 - zhouyifan279
@zhuqi-lucas - zhuqi-lucas
@zwangsheng - zwangsheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #36901:
URL: https://github.com/apache/spark/pull/36901#discussion_r899999093
##########
dev/create-release/known_translations:
##########
@@ -416,3 +416,94 @@ zsxwing - Shixiong Zhu
zuotingbing - Tingbing Zuo
zuxqoj - Shekhar Bansal
zzcclp - Zhichao Zhang
+Alfonso - Alfonso Buono
Review Comment:
Shall we sort them in alphabetical order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36901: [MINOR] Update known_translations
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36901:
URL: https://github.com/apache/spark/pull/36901#issuecomment-1158778589
I am closing this PR because some mappings are wrong. Sorry all for massive pings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org