You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "ministat (via GitHub)" <gi...@apache.org> on 2023/05/04 05:12:17 UTC
[GitHub] [tinkerpop] ministat opened a new pull request, #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
ministat opened a new pull request, #2053:
URL: https://github.com/apache/tinkerpop/pull/2053
In production environment, it is dangerous to delete a folder which is not empty. In order to avoid any wrong operations, it is better ask user to delete it manually if it is not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk merged pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk merged PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on a diff in pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on code in PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#discussion_r1199338778
##########
hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/Constants.java:
##########
@@ -73,6 +73,7 @@ private Constants() {
public static final String GREMLIN_SPARK_PERSIST_STORAGE_LEVEL = "gremlin.spark.persistStorageLevel";
public static final String GREMLIN_SPARK_SKIP_PARTITIONER = "gremlin.spark.skipPartitioner"; // don't partition the loadedGraphRDD
public static final String GREMLIN_SPARK_SKIP_GRAPH_CACHE = "gremlin.spark.skipGraphCache"; // don't cache the loadedGraphRDD (ignores graphStorageLevel)
+ public static final String GREMLIN_SPARK_DONT_DELETE_NONE_EMPTY_OUTPUT = "gremlin.spark.dontDeleteNonEmptyOutput"; // don't delete the output if it is not empty
Review Comment:
Nit: I think there is a typo here. It should probably be GREMLIN_SPARK_DONT_DELETE_NON_EMPTY_OUTPUT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1555194730
Could you please also add a CHANGELOG entry?
VOTE +1, pending minor fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] ministat commented on pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "ministat (via GitHub)" <gi...@apache.org>.
ministat commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1560341638
@kenhuuu Thanks. I have added a new entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1563641903
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] ministat commented on a diff in pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "ministat (via GitHub)" <gi...@apache.org>.
ministat commented on code in PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#discussion_r1199532084
##########
hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/Constants.java:
##########
@@ -73,6 +73,7 @@ private Constants() {
public static final String GREMLIN_SPARK_PERSIST_STORAGE_LEVEL = "gremlin.spark.persistStorageLevel";
public static final String GREMLIN_SPARK_SKIP_PARTITIONER = "gremlin.spark.skipPartitioner"; // don't partition the loadedGraphRDD
public static final String GREMLIN_SPARK_SKIP_GRAPH_CACHE = "gremlin.spark.skipGraphCache"; // don't cache the loadedGraphRDD (ignores graphStorageLevel)
+ public static final String GREMLIN_SPARK_DONT_DELETE_NONE_EMPTY_OUTPUT = "gremlin.spark.dontDeleteNonEmptyOutput"; // don't delete the output if it is not empty
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] ministat commented on pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "ministat (via GitHub)" <gi...@apache.org>.
ministat commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1555433075
>Could you please also add a CHANGELOG entry?
I have no idea for which CHANGELOG entry I should add. My working branch is 3.5-dev and I don't know which release will include this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1560258591
> I have no idea for which CHANGELOG entry I should add. My working branch is 3.5-dev and I don't know which release will include this patch.
The CHANGELOGs for each subsequent branch state that they include the items from the previous branches. Since you are merging into 3.5-dev, you can just add a short entry to the upcoming release for 3.5. Just place it here https://github.com/apache/tinkerpop/blob/3.5-dev/CHANGELOG.asciidoc#L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2053: [TINKERPOP-2941] Stop deleting the output location if it is not empty
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2053:
URL: https://github.com/apache/tinkerpop/pull/2053#issuecomment-1534112691
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2053?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2053](https://app.codecov.io/gh/apache/tinkerpop/pull/2053?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (301095f) into [3.5-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/3a9ca15e43b1b215f59a9f4c35a34e2a8caab6f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a9ca15) will **decrease** coverage by `5.18%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.5-dev #2053 +/- ##
=============================================
- Coverage 69.42% 64.24% -5.18%
=============================================
Files 866 25 -841
Lines 41251 3759 -37492
Branches 5442 0 -5442
=============================================
- Hits 28637 2415 -26222
+ Misses 10708 1166 -9542
+ Partials 1906 178 -1728
```
[see 841 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2053/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org