You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "MagicBoost (via GitHub)" <gi...@apache.org> on 2024/01/08 03:19:45 UTC
[PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
MagicBoost opened a new pull request, #39497:
URL: https://github.com/apache/arrow/pull/39497
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
closes: #35718
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
Fix painc writing with DeltaBinaryPacked or DeltaByteArray when column only has nulls
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
Yes
- add a test writing nulls to columns with DeltaBinaryPacked / DeltaByteArray / DeltaLengthByteArray encodings
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "MagicBoost (via GitHub)" <gi...@apache.org>.
MagicBoost commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1444200146
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
Review Comment:
Strictly speaking this is not necessary，I just copy the previous test and want to add some simple tests on nested formats.
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
+ {Name: "f3", Type: arrow.BinaryTypes.String, Nullable: true},
+ {Name: "f4", Type: arrow.ListOf(arrow.BinaryTypes.String)},
+ {Name: "f5", Type: arrow.BinaryTypes.LargeString, Nullable: true},
+ {Name: "f6", Type: arrow.ListOf(arrow.BinaryTypes.LargeString)},
+ }, nil)
+ bldr := array.NewRecordBuilder(memory.DefaultAllocator, sc)
+ defer bldr.Release()
+ for _, b := range bldr.Fields() {
+ b.AppendNull()
+ }
+
+ rec := bldr.NewRecord()
+ defer rec.Release()
+
+ props := parquet.NewWriterProperties(
+ parquet.WithVersion(parquet.V1_0),
+ parquet.WithDictionaryDefault(false),
+ parquet.WithEncodingFor("f1", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f2", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f3", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f4", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f5", parquet.Encodings.DeltaLengthByteArray),
+ parquet.WithEncodingFor("f6", parquet.Encodings.DeltaLengthByteArray),
Review Comment:
I don't get it, I have already used these encoders testing nulls encoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #39497:
URL: https://github.com/apache/arrow/pull/39497#issuecomment-1881777196
I've rebased this and fixed the conflict after merging my change. Shrinks this down to a fairly small change plus all the new tests. This all seems good to me assuming that all the CI passes. Thanks much @MagicBoost !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39497:
URL: https://github.com/apache/arrow/pull/39497#issuecomment-1885848898
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f0879ed3544bb12ee306eae1fb5c6d924dde02ed.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20363448217) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39497:
URL: https://github.com/apache/arrow/pull/39497#issuecomment-1880332883
:warning: GitHub issue #35718 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1445295739
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
Review Comment:
It's good to ensure we're testing nulls for multiple types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1444150606
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
+ {Name: "f3", Type: arrow.BinaryTypes.String, Nullable: true},
+ {Name: "f4", Type: arrow.ListOf(arrow.BinaryTypes.String)},
+ {Name: "f5", Type: arrow.BinaryTypes.LargeString, Nullable: true},
+ {Name: "f6", Type: arrow.ListOf(arrow.BinaryTypes.LargeString)},
+ }, nil)
+ bldr := array.NewRecordBuilder(memory.DefaultAllocator, sc)
+ defer bldr.Release()
+ for _, b := range bldr.Fields() {
+ b.AppendNull()
+ }
+
+ rec := bldr.NewRecord()
+ defer rec.Release()
+
+ props := parquet.NewWriterProperties(
+ parquet.WithVersion(parquet.V1_0),
+ parquet.WithDictionaryDefault(false),
+ parquet.WithEncodingFor("f1", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f2", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f3", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f4", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f5", parquet.Encodings.DeltaLengthByteArray),
+ parquet.WithEncodingFor("f6", parquet.Encodings.DeltaLengthByteArray),
Review Comment:
( Maybe `go/parquet/internal/encoding/encoding_test.go` is also a good place for testing?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "MagicBoost (via GitHub)" <gi...@apache.org>.
MagicBoost commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1444250800
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
+ {Name: "f3", Type: arrow.BinaryTypes.String, Nullable: true},
+ {Name: "f4", Type: arrow.ListOf(arrow.BinaryTypes.String)},
+ {Name: "f5", Type: arrow.BinaryTypes.LargeString, Nullable: true},
+ {Name: "f6", Type: arrow.ListOf(arrow.BinaryTypes.LargeString)},
+ }, nil)
+ bldr := array.NewRecordBuilder(memory.DefaultAllocator, sc)
+ defer bldr.Release()
+ for _, b := range bldr.Fields() {
+ b.AppendNull()
+ }
+
+ rec := bldr.NewRecord()
+ defer rec.Release()
+
+ props := parquet.NewWriterProperties(
+ parquet.WithVersion(parquet.V1_0),
+ parquet.WithDictionaryDefault(false),
+ parquet.WithEncodingFor("f1", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f2", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f3", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f4", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f5", parquet.Encodings.DeltaLengthByteArray),
+ parquet.WithEncodingFor("f6", parquet.Encodings.DeltaLengthByteArray),
Review Comment:
Ok, I added more encording tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1444149655
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
Review Comment:
Hmm why List is tested here?
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
+ {Name: "f3", Type: arrow.BinaryTypes.String, Nullable: true},
+ {Name: "f4", Type: arrow.ListOf(arrow.BinaryTypes.String)},
+ {Name: "f5", Type: arrow.BinaryTypes.LargeString, Nullable: true},
+ {Name: "f6", Type: arrow.ListOf(arrow.BinaryTypes.LargeString)},
+ }, nil)
+ bldr := array.NewRecordBuilder(memory.DefaultAllocator, sc)
+ defer bldr.Release()
+ for _, b := range bldr.Fields() {
+ b.AppendNull()
+ }
+
+ rec := bldr.NewRecord()
+ defer rec.Release()
+
+ props := parquet.NewWriterProperties(
+ parquet.WithVersion(parquet.V1_0),
+ parquet.WithDictionaryDefault(false),
+ parquet.WithEncodingFor("f1", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f2", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f3", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f4", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f5", parquet.Encodings.DeltaLengthByteArray),
+ parquet.WithEncodingFor("f6", parquet.Encodings.DeltaLengthByteArray),
Review Comment:
Would you mind testing all these encoders?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "MagicBoost (via GitHub)" <gi...@apache.org>.
MagicBoost commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1444200262
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
+ {Name: "f3", Type: arrow.BinaryTypes.String, Nullable: true},
+ {Name: "f4", Type: arrow.ListOf(arrow.BinaryTypes.String)},
+ {Name: "f5", Type: arrow.BinaryTypes.LargeString, Nullable: true},
+ {Name: "f6", Type: arrow.ListOf(arrow.BinaryTypes.LargeString)},
+ }, nil)
+ bldr := array.NewRecordBuilder(memory.DefaultAllocator, sc)
+ defer bldr.Release()
+ for _, b := range bldr.Fields() {
+ b.AppendNull()
+ }
+
+ rec := bldr.NewRecord()
+ defer rec.Release()
+
+ props := parquet.NewWriterProperties(
+ parquet.WithVersion(parquet.V1_0),
+ parquet.WithDictionaryDefault(false),
+ parquet.WithEncodingFor("f1", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f2", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f3", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f4", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f5", parquet.Encodings.DeltaLengthByteArray),
+ parquet.WithEncodingFor("f6", parquet.Encodings.DeltaLengthByteArray),
Review Comment:
There is no panic or error happens in the encoding process, panic happens when writing data into a file (call written function on a nil bitWriter not inited).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #39497:
URL: https://github.com/apache/arrow/pull/39497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #39497:
URL: https://github.com/apache/arrow/pull/39497#issuecomment-1884163057
```go
// EstimatedDataEncodedSize returns the current number of bytes that have
// been buffered so far
func (enc *PlainBooleanEncoder) EstimatedDataEncodedSize() int64 {
return int64(enc.sink.Len() + int(bitutil.BytesForBits(int64(enc.wr.Pos()))))
}
```
@zeroshade This might suffer from problem when `enc.wr == nil`. However, if all input is null, the `Put` would also be called here...Would we leave it here or also fixing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #39497:
URL: https://github.com/apache/arrow/pull/39497#discussion_r1444202093
##########
go/parquet/pqarrow/encode_arrow_test.go:
##########
@@ -427,6 +427,44 @@ func TestWriteEmptyLists(t *testing.T) {
require.NoError(t, err)
}
+func TestWriteAllNullsWithDeltaEncoding(t *testing.T) {
+ sc := arrow.NewSchema([]arrow.Field{
+ {Name: "f1", Type: arrow.PrimitiveTypes.Int64, Nullable: true},
+ {Name: "f2", Type: arrow.ListOf(arrow.FixedWidthTypes.Date32)},
+ {Name: "f3", Type: arrow.BinaryTypes.String, Nullable: true},
+ {Name: "f4", Type: arrow.ListOf(arrow.BinaryTypes.String)},
+ {Name: "f5", Type: arrow.BinaryTypes.LargeString, Nullable: true},
+ {Name: "f6", Type: arrow.ListOf(arrow.BinaryTypes.LargeString)},
+ }, nil)
+ bldr := array.NewRecordBuilder(memory.DefaultAllocator, sc)
+ defer bldr.Release()
+ for _, b := range bldr.Fields() {
+ b.AppendNull()
+ }
+
+ rec := bldr.NewRecord()
+ defer rec.Release()
+
+ props := parquet.NewWriterProperties(
+ parquet.WithVersion(parquet.V1_0),
+ parquet.WithDictionaryDefault(false),
+ parquet.WithEncodingFor("f1", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f2", parquet.Encodings.DeltaBinaryPacked),
+ parquet.WithEncodingFor("f3", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f4", parquet.Encodings.DeltaByteArray),
+ parquet.WithEncodingFor("f5", parquet.Encodings.DeltaLengthByteArray),
+ parquet.WithEncodingFor("f6", parquet.Encodings.DeltaLengthByteArray),
Review Comment:
In this patch we check DeltaBinaryPack and DeltaByteArray. DeltaLengthByteArray uses DeltaBinaryPack, and DeltaByteArray uses DeltaLengthByteArray. So I think it's ok to testing them
Besides, there're some other encodings: RleBoolean, Plain ..etc. Should we also testing them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35718: [Go][Parquet] Fix for null-only encoding panic [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #39497:
URL: https://github.com/apache/arrow/pull/39497#issuecomment-1880345517
(I'm afraid https://github.com/apache/arrow/pull/39347/files does the similiar things but less than your contributions in this patch, but it doesn't get merged, I will wait @zeroshade for a while...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org