You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/15 16:38:27 UTC

[GitHub] [iceberg] gaborkaszab opened a new pull request, #5771: Core: Deprecate functions in DeleteWriters

gaborkaszab opened a new pull request, #5771:
URL: https://github.com/apache/iceberg/pull/5771

   There are some functions marked to be deprecated in 0.14. As we passed that release already and getting close to 1.0.0 this might be the time to drop them.
   This patch takes care of the functions in EqualityDeleteWriter and PositionDeleteWriter classes in the core/ folder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] nastra commented on a diff in pull request #5771: Core: Deprecate functions in DeleteWriters

Posted by GitBox <gi...@apache.org>.
nastra commented on code in PR #5771:
URL: https://github.com/apache/iceberg/pull/5771#discussion_r984294797


##########
core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java:
##########
@@ -167,7 +167,9 @@ private void flushDeletes() {
         List<PosRow<T>> positions = posDeletes.get(wrapper.set(path));
         positions.sort(Comparator.comparingLong(PosRow::pos));
 
-        positions.forEach(posRow -> closeableWriter.delete(path, posRow.pos(), posRow.row()));
+        PositionDelete<T> posDelete = PositionDelete.create();
+        positions.forEach(
+            posRow -> closeableWriter.write(posDelete.set(path, posRow.pos(), posRow.row())));

Review Comment:
   I'll make sure to be more careful when reviewing such behavioral changes and I opened https://github.com/apache/iceberg/pull/5896 to address that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] danielcweeks merged pull request #5771: Core: Deprecate functions in DeleteWriters

Posted by GitBox <gi...@apache.org>.
danielcweeks merged PR #5771:
URL: https://github.com/apache/iceberg/pull/5771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on a diff in pull request #5771: Core: Deprecate functions in DeleteWriters

Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5771:
URL: https://github.com/apache/iceberg/pull/5771#discussion_r984033327


##########
core/src/main/java/org/apache/iceberg/io/SortedPosDeleteWriter.java:
##########
@@ -167,7 +167,9 @@ private void flushDeletes() {
         List<PosRow<T>> positions = posDeletes.get(wrapper.set(path));
         positions.sort(Comparator.comparingLong(PosRow::pos));
 
-        positions.forEach(posRow -> closeableWriter.delete(path, posRow.pos(), posRow.row()));
+        PositionDelete<T> posDelete = PositionDelete.create();
+        positions.forEach(
+            posRow -> closeableWriter.write(posDelete.set(path, posRow.pos(), posRow.row())));

Review Comment:
   @nastra, this changes the behavior to create a new `PositionDelete` for every delete rather than reusing the same one. Can you follow up with a fix to restore the old behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] danielcweeks commented on pull request #5771: Core: Deprecate functions in DeleteWriters

Posted by GitBox <gi...@apache.org>.
danielcweeks commented on PR #5771:
URL: https://github.com/apache/iceberg/pull/5771#issuecomment-1261058761

   Thanks @gaborkaszab !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org