[jira] [Updated] (DERBY-2051) CachedItem's comments and code are inconsistent wrt. syncronization

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-2051:
--------------------------------------
    Attachment: d2051-1a-remove.diff

DERBY-6240 removed the old cache manager from trunk, so now the CachedItem class is not in use. I suggest we just remove it and close this issue.

The attached patch [^d2051-1a-remove.diff] removes the class. All regression tests passed.

> CachedItem's comments and code are inconsistent wrt. syncronization
> -------------------------------------------------------------------
>
>                 Key: DERBY-2051
>                 URL: https://issues.apache.org/jira/browse/DERBY-2051
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>    Affects Versions: 10.2.1.6
>            Reporter: Dyre Tjeldvoll
>         Attachments: d2051-1a-remove.diff
>
>
> The javadoc comment for CachedItem says that the state should only be accessed by the CacheManager, and that no synchronization is required. But a subset of the accessors/mutators are declared synchronized. If synchronization is unnecessary it should be removed to improve performance. If it is required, this should be properly explained in the comments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)