You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/02/04 09:33:00 UTC

[jira] [Commented] (AVRO-3361) Simplify if statement in NullCodec

    [ https://issues.apache.org/jira/browse/AVRO-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486907#comment-17486907 ] 

ASF subversion and git services commented on AVRO-3361:
-------------------------------------------------------

Commit e57df5ea723fe403ab17d012180564ffbce1f993 in avro's branch refs/heads/master from Kyle Schoonover
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=e57df5e ]

AVRO-3361 simplify if statement (#1512)

* AVRO-3360 Updated XML documentation

* Revert "AVRO-3360 Updated XML documentation"

This reverts commit b8601c072a5083380d30b580804dd0908b8cf4cc.

* AVRO-3361 simplify if statement

* AVRO-3361: Simplify boolean expression

Co-authored-by: Kyle T. Schoonover <Ky...@nordstrom.com>
Co-authored-by: Martin Grigorov <ma...@users.noreply.github.com>

> Simplify if statement in NullCodec
> ----------------------------------
>
>                 Key: AVRO-3361
>                 URL: https://issues.apache.org/jira/browse/AVRO-3361
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.1
>            Reporter: Kyle Schoonover
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Example:
> Change this:
> {code:java}
>         public override bool Equals(object other)
>         {
>             if (this == other)
>                 return true;
>             return this.GetType().Name == other.GetType().Name;
>         } {code}
> to this:
> {code:java}
>         public override bool Equals(object other)
>         {
>             return this == other ? true : GetType().Name == other.GetType().Name;
>         }{code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)