You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2012/04/24 15:52:04 UTC
svn commit: r1329724 - in
/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl:
GenericKeyedObjectPool.java GenericObjectPool.java
Author: markt
Date: Tue Apr 24 13:52:04 2012
New Revision: 1329724
URL: http://svn.apache.org/viewvc?rev=1329724&view=rev
Log:
Align GOP/GKOP constructor comments
Modified:
commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java?rev=1329724&r1=1329723&r2=1329724&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java Tue Apr 24 13:52:04 2012
@@ -214,8 +214,7 @@ public class GenericKeyedObjectPool<K,T>
//--- constructors -----------------------------------------------
/**
- * Create a new <code>GenericKeyedObjectPool</code> using defaults and no
- * factory.
+ * Create a new <code>GenericKeyedObjectPool</code> using defaults.
*/
public GenericKeyedObjectPool(KeyedPoolableObjectFactory<K,T> factory) {
this(factory, new GenericKeyedObjectPoolConfig());
@@ -232,7 +231,6 @@ public class GenericKeyedObjectPool<K,T>
*/
public GenericKeyedObjectPool(KeyedPoolableObjectFactory<K,T> factory,
GenericKeyedObjectPoolConfig config) {
- // Copy the settings from the config
this.factory = factory;
// save the current CCL to be used later by the evictor Thread
factoryClassLoader = Thread.currentThread().getContextClassLoader();
Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java?rev=1329724&r1=1329723&r2=1329724&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java (original)
+++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java Tue Apr 24 13:52:04 2012
@@ -181,12 +181,21 @@ public class GenericObjectPool<T> extend
// --- constructors -----------------------------------------------
/**
- * Create a new <tt>GenericObjectPool</tt> with default properties.
+ * Create a new <code>GenericObjectPool</code> using default.
*/
public GenericObjectPool(PoolableObjectFactory<T> factory) {
this(factory, new GenericObjectPoolConfig());
}
+ /**
+ * Create a new <code>GenericObjectPool</code> using a specific
+ * configuration.
+ *
+ * @param config The configuration to use for this pool instance. The
+ * configuration is used by value. Subsequent changes to
+ * the configuration object will not be reflected in the
+ * pool.
+ */
public GenericObjectPool(PoolableObjectFactory<T> factory,
GenericObjectPoolConfig config) {
this.factory = factory;
@@ -250,9 +259,6 @@ public class GenericObjectPool<T> extend
this.creationStackTrace = getStackTrace(new Exception());
}
-
- // --- public methods ---------------------------------------------
-
// --- configuration methods --------------------------------------
/**