You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/03/07 17:16:51 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #9501: Enable external file loading for sni.yaml.

maskit commented on code in PR #9501:
URL: https://github.com/apache/trafficserver/pull/9501#discussion_r1128250075


##########
iocore/net/SSLSNIConfig.cc:
##########
@@ -93,6 +96,78 @@ NamedElement::set_regex_name(const std::string &regex_name)
 ////
 // SNIConfigParams
 //
+// ----
+
+SNI_IpAllow::SNI_IpAllow(std::string &ip_allow_list, std::string const &servername)

Review Comment:
   I don't think P_SNIActionPerformer is the best place to have this at all, but why here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org