[GitHub] peng-yongsheng commented on a change in pull request #1921: Remove duration condition when query conjecture node

[GitBox <gi...@apache.org>]

peng-yongsheng commented on a change in pull request #1921: Remove duration condition when query conjecture node
URL: https://github.com/apache/incubator-skywalking/pull/1921#discussion_r234410651
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/MetadataQueryEsDAO.java
 ##########
 @@ -75,7 +75,6 @@ public MetadataQueryEsDAO(ElasticSearchClient client) {
         SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource();
 
         BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
-        boolQueryBuilder.must().add(timeRangeQueryBuild(startTimestamp, endTimestamp));
         boolQueryBuilder.must().add(QueryBuilders.termQuery(NetworkAddressInventory.SRC_LAYER, srcLayer));
 
         sourceBuilder.query(boolQueryBuilder);
 
 Review comment:
   Boolean query builder is use for two query condition, but when you delete one of them, you can set query directly.
   
   sourceBuilder.query(QueryBuilders.termQuery(NetworkAddressInventory.SRC_LAYER, srcLayer));

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services