[GitHub] [airflow] Fokko commented on issue #5779: [AIRLFOW-5163] Default do_xcom_push to False

[GitBox <gi...@apache.org>]

Fokko commented on issue #5779: [AIRLFOW-5163] Default do_xcom_push to False
URL: https://github.com/apache/airflow/pull/5779#issuecomment-545386378
 
 
   @bolkedebruin I think it should be set to `False` by default, for two reasons:
   - It will potentially pollute the database by inserting xcom data, while not using it. This should be a deliberate choice. Most of the DAGs won't use xcom.
   - If you by accident push a big object, it will throw an error because the payload is bigger than 48k: https://github.com/apache/airflow/blob/master/airflow/models/xcom.py#L36
   
   @potiuk Thanks for figuring out which operators return data to xcom. However, if something is being pushed to xcom, it doesn't mean that it is being used somewhere downstream or in another dag. I believe we should go through the list and check where it actually makes sense to push it to xcom. I'm happy to help on this as well :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services