You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2008/02/13 23:21:49 UTC

DO NOT REPLY [Bug 44418] New: - [PATCH] Modified CSV Data Set for independent file reading

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44418>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44418

           Summary: [PATCH] Modified CSV Data Set for independent file
                    reading
           Product: JMeter
           Version: 2.3.1
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: frankyhro@gmx.de


Hello,

this is my first patch for JMeter.
If you have two or more CSV Data Sets in your test plan, which
use the same file you may have a problem (like me). The file is
only opened once (one instance). So every read from a CSV-file 
(regardless of which thread) will cause a jump to the next line.
I wrote a patch so you can choose in the CSV-Data Set whether the file
reading shall be independet (the file will be opened again even it
is already open ) or not (the old behavior). 
A screenshot is also added to the archive.

Please contact me if you have questions or annotations.

Thanks

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 44418] - [PATCH] Modified CSV Data Set for independent file reading

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44418>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44418





------- Additional Comments From sebb@apache.org  2008-02-20 18:43 -------
Just tried the patch - it does not work reliably.

The FileServer relies on retrieving the FileEntry using just the file name as
key, so if the same name is used more than once, the second entry will overwrite
the first.

It is too restrictive to insist on unique file names.

For independent files, the FileServer could use the CSV Dataset instance (this)
as the key.

There's also a typo in the patch - the new reserveFile parameter should be
boolean, not Boolean.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 44418] - [PATCH] Modified CSV Data Set for independent file reading

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44418>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44418





------- Additional Comments From tobias_henkel@gmx.de  2008-02-22 08:28 -------
Created an attachment (id=21580)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21580&action=view)
Another patch for an independent CSV Data Source

I've created a similar patch which makes the CSV Data Source optional
independent.
You can also specify, how many loops throug the file you want to do if recycle
is TRUE.

Greetings

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 44418] - [PATCH] Modified CSV Data Set for independent file reading

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44418>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44418





------- Additional Comments From frankyhro@gmx.de  2008-02-17 10:09 -------
Created an attachment (id=21550)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21550&action=view)
A testplan for my patch.

Here is a testplan for my patch. You need beanshell for this.
Two threads with two CSV Data Sets are reading from the same csv-file.
Without my patch the output (print) is like:
line1
line2

with my patch you can set on both CSV-Data Sets "Independent CSV-Data reading"
to true:
line1
line1

The csv-data is read independently. It doesn't matter if other threads are
reading from the same file.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org

DO NOT REPLY [Bug 44418] - [PATCH] Modified CSV Data Set for independent file reading

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44418>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44418





------- Additional Comments From frankyhro@gmx.de  2008-02-13 14:23 -------
Created an attachment (id=21524)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=21524&action=view)
Patch with Screenshot


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org