You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2015/01/19 06:46:09 UTC
[2/2] flink git commit: [tests] Minor cleanup of compiler warnings.
[tests] Minor cleanup of compiler warnings.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/6cc35837
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/6cc35837
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/6cc35837
Branch: refs/heads/master
Commit: 6cc35837f4513050a4f844769ca4dd55e2dd38ba
Parents: 020b282
Author: Stephan Ewen <se...@apache.org>
Authored: Sun Jan 18 18:25:58 2015 -0800
Committer: Stephan Ewen <se...@apache.org>
Committed: Sun Jan 18 18:49:40 2015 -0800
----------------------------------------------------------------------
.../apache/flink/api/java/functions/ClosureCleanerTest.java | 5 ++++-
.../java/org/apache/flink/api/java/operators/KeysTest.java | 6 ++----
.../java/org/apache/flink/api/java/operators/NamesTest.java | 5 +++--
.../java/operators/translation/DistinctTranslationTest.java | 2 +-
.../typeutils/runtime/AbstractGenericTypeSerializerTest.java | 3 ---
5 files changed, 10 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/6cc35837/flink-java/src/test/java/org/apache/flink/api/java/functions/ClosureCleanerTest.java
----------------------------------------------------------------------
diff --git a/flink-java/src/test/java/org/apache/flink/api/java/functions/ClosureCleanerTest.java b/flink-java/src/test/java/org/apache/flink/api/java/functions/ClosureCleanerTest.java
index 0d7235f..496c61a 100644
--- a/flink-java/src/test/java/org/apache/flink/api/java/functions/ClosureCleanerTest.java
+++ b/flink-java/src/test/java/org/apache/flink/api/java/functions/ClosureCleanerTest.java
@@ -91,6 +91,7 @@ interface MapCreator {
MapFunction<Integer, Integer> getMap();
}
+@SuppressWarnings("serial")
class NonSerializableMapCreator implements MapCreator {
@Override
@@ -105,7 +106,7 @@ class NonSerializableMapCreator implements MapCreator {
}
-
+@SuppressWarnings("serial")
class SerializableMapCreator implements MapCreator, Serializable {
private int add = 0;
@@ -126,6 +127,7 @@ class SerializableMapCreator implements MapCreator, Serializable {
}
+@SuppressWarnings("serial")
class NestedSerializableMapCreator implements MapCreator, Serializable {
private int add = 0;
@@ -172,6 +174,7 @@ class NestedNonSerializableMapCreator implements MapCreator {
return inner.getMap();
}
+ @SuppressWarnings("serial")
class InnerSerializableMapCreator implements MapCreator, Serializable {
@Override
http://git-wip-us.apache.org/repos/asf/flink/blob/6cc35837/flink-java/src/test/java/org/apache/flink/api/java/operators/KeysTest.java
----------------------------------------------------------------------
diff --git a/flink-java/src/test/java/org/apache/flink/api/java/operators/KeysTest.java b/flink-java/src/test/java/org/apache/flink/api/java/operators/KeysTest.java
index 37a117f..c8e5ba3 100644
--- a/flink-java/src/test/java/org/apache/flink/api/java/operators/KeysTest.java
+++ b/flink-java/src/test/java/org/apache/flink/api/java/operators/KeysTest.java
@@ -100,7 +100,6 @@ public class KeysTest {
BasicTypeInfo.STRING_TYPE_INFO,
new TupleTypeInfo<Tuple3<String, String, String>>(BasicTypeInfo.STRING_TYPE_INFO,BasicTypeInfo.STRING_TYPE_INFO,BasicTypeInfo.STRING_TYPE_INFO),
BasicTypeInfo.STRING_TYPE_INFO);
- ExpressionKeys<Tuple3<String, Tuple3<String, String, String>, String>> fpk;
String[][] tests = new String[][] {
new String[] {"f0.f1"}, // nesting into unnested
@@ -113,7 +112,7 @@ public class KeysTest {
for(int i = 0; i < tests.length; i++) {
Throwable e = null;
try {
- fpk = new ExpressionKeys<Tuple3<String, Tuple3<String, String, String>, String>>(tests[i], typeInfo);
+ new ExpressionKeys<Tuple3<String, Tuple3<String, String, String>, String>>(tests[i], typeInfo);
} catch(Throwable t) {
// System.err.println("Message: "+t.getMessage()); t.printStackTrace();
e = t;
@@ -125,7 +124,6 @@ public class KeysTest {
@Test
public void testInvalidPojo() throws Throwable {
TypeInformation<ComplexNestedClass> ti = TypeExtractor.getForClass(ComplexNestedClass.class);
- ExpressionKeys<ComplexNestedClass> ek;
String[][] tests = new String[][] {
new String[] {"nonexistent"},
@@ -135,7 +133,7 @@ public class KeysTest {
for(int i = 0; i < tests.length; i++) {
Throwable e = null;
try {
- ek = new ExpressionKeys<ComplexNestedClass>(tests[i], ti);
+ new ExpressionKeys<ComplexNestedClass>(tests[i], ti);
} catch(Throwable t) {
// System.err.println("Message: "+t.getMessage()); t.printStackTrace();
e = t;
http://git-wip-us.apache.org/repos/asf/flink/blob/6cc35837/flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java
----------------------------------------------------------------------
diff --git a/flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java b/flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java
index c3cac68..2164c79 100644
--- a/flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java
+++ b/flink-java/src/test/java/org/apache/flink/api/java/operators/NamesTest.java
@@ -41,6 +41,7 @@ import org.junit.Test;
/**
* Test proper automated assignment of the transformation's name, if not set by the user.
*/
+@SuppressWarnings("serial")
public class NamesTest implements Serializable {
@Test
@@ -60,7 +61,7 @@ public class NamesTest implements Serializable {
}
}).output(new DiscardingOuputFormat<String>());
JavaPlan plan = env.createProgramPlan();
- testForName("Filter at testDefaultName(NamesTest.java:54)", plan);
+ testForName("Filter at testDefaultName(NamesTest.java:55)", plan);
}
@Test
@@ -102,7 +103,7 @@ public class NamesTest implements Serializable {
@Override
public boolean preVisit(Operator<?> visitable) {
if(visitable instanceof JoinOperatorBase) {
- Assert.assertEquals("Join at testJoinWith(NamesTest.java:92)", visitable.getName());
+ Assert.assertEquals("Join at testJoinWith(NamesTest.java:93)", visitable.getName());
}
return true;
}
http://git-wip-us.apache.org/repos/asf/flink/blob/6cc35837/flink-java/src/test/java/org/apache/flink/api/java/operators/translation/DistinctTranslationTest.java
----------------------------------------------------------------------
diff --git a/flink-java/src/test/java/org/apache/flink/api/java/operators/translation/DistinctTranslationTest.java b/flink-java/src/test/java/org/apache/flink/api/java/operators/translation/DistinctTranslationTest.java
index 6eb536d..0cf2ee2 100644
--- a/flink-java/src/test/java/org/apache/flink/api/java/operators/translation/DistinctTranslationTest.java
+++ b/flink-java/src/test/java/org/apache/flink/api/java/operators/translation/DistinctTranslationTest.java
@@ -281,7 +281,7 @@ public class DistinctTranslationTest {
private static final long serialVersionUID = 1L;
public int myInt;
- @SuppressWarnings("unused")
+
public CustomType() {};
public CustomType(int i) {
http://git-wip-us.apache.org/repos/asf/flink/blob/6cc35837/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/AbstractGenericTypeSerializerTest.java
----------------------------------------------------------------------
diff --git a/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/AbstractGenericTypeSerializerTest.java b/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/AbstractGenericTypeSerializerTest.java
index 2a11bd7..059c78d 100644
--- a/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/AbstractGenericTypeSerializerTest.java
+++ b/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/AbstractGenericTypeSerializerTest.java
@@ -21,13 +21,10 @@ package org.apache.flink.api.java.typeutils.runtime;
import org.apache.flink.api.common.typeutils.SerializerTestInstance;
import org.apache.flink.api.common.typeutils.TypeSerializer;
import org.apache.flink.util.StringUtils;
-import org.joda.time.DateTime;
import org.junit.Test;
import java.util.ArrayList;
-import java.util.Collection;
import java.util.HashMap;
-import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Random;