You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/05/10 16:19:47 UTC

[GitHub] [accumulo] milleruntime commented on a change in pull request #2087: Fix #2070 address ShellServerIT test failures

milleruntime commented on a change in pull request #2087:
URL: https://github.com/apache/accumulo/pull/2087#discussion_r629496618



##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1421,21 +1431,24 @@ public void help() throws Exception {
     }
   }
 
+  // TODO - evaluate this test is testing what is expected or history is working.
   @Test
   public void history() throws Exception {
     final String table = name.getMethodName();
 
     ts.exec("history -c", true);
     ts.exec("createtable " + table);
     ts.exec("deletetable -f " + table);
+    // TODO - this may be passing only because method name is history.

Review comment:
       OK I opened up a separate issue to fix the history test. https://github.com/apache/accumulo/issues/2091




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org