You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by sh...@apache.org on 2020/11/29 17:58:18 UTC

[incubator-gobblin] branch master updated: [GOBBLIN-132] Fix Jackson version clash, Parquet downgrade

This is an automated email from the ASF dual-hosted git repository.

shirshanka pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-gobblin.git


The following commit(s) were added to refs/heads/master by this push:
     new 4de9d46  [GOBBLIN-132] Fix Jackson version clash, Parquet downgrade
4de9d46 is described below

commit 4de9d464077af45744fc40c27d083e521e23603c
Author: treff7es <tr...@gmail.com>
AuthorDate: Sun Nov 29 09:56:01 2020 -0800

    [GOBBLIN-132] Fix Jackson version clash, Parquet downgrade
    
    Downgrading parquet to use an older version of
    jackson which does not clash with avro.
    
    This is the jackson commit which caused issue:
    https://github.com/FasterXML/jackson-core/commit/3
    5f3ab4d0512edc2d1ce13a7f43cd75b3c63c797
    
    Closes #3160 from
    treff7es/jackson_version_clash_fix
---
 .../gobblin/example/wikipedia/EmbeddedWikipediaExample.java       | 4 +---
 gradle/scripts/dependencyDefinitions.gradle                       | 8 ++++----
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/gobblin-example/src/main/java/org/apache/gobblin/example/wikipedia/EmbeddedWikipediaExample.java b/gobblin-example/src/main/java/org/apache/gobblin/example/wikipedia/EmbeddedWikipediaExample.java
index 83dc333..bf669fe 100644
--- a/gobblin-example/src/main/java/org/apache/gobblin/example/wikipedia/EmbeddedWikipediaExample.java
+++ b/gobblin-example/src/main/java/org/apache/gobblin/example/wikipedia/EmbeddedWikipediaExample.java
@@ -22,8 +22,6 @@ import java.net.URISyntaxException;
 
 import org.apache.commons.cli.CommandLine;
 
-import com.google.common.base.Joiner;
-
 import org.apache.gobblin.annotation.Alias;
 import org.apache.gobblin.configuration.ConfigurationKeys;
 import org.apache.gobblin.publisher.BaseDataPublisher;
@@ -74,7 +72,7 @@ public class EmbeddedWikipediaExample extends EmbeddedGobblin {
     } catch (URISyntaxException | SpecNotFoundException exc) {
       throw new RuntimeException("Could not instantiate an " + EmbeddedWikipediaExample.class.getName(), exc);
     }
-    this.setConfiguration("titles", Joiner.on(",").join(topics));
+    this.setConfiguration("titles", String.join(",", topics));
   }
 
   /**
diff --git a/gradle/scripts/dependencyDefinitions.gradle b/gradle/scripts/dependencyDefinitions.gradle
index f404f49..a9c0ac4 100644
--- a/gradle/scripts/dependencyDefinitions.gradle
+++ b/gradle/scripts/dependencyDefinitions.gradle
@@ -177,10 +177,10 @@ ext.externalDependency = [
     "orcMapreduce":"org.apache.orc:orc-mapreduce:1.6.3:nohive",
     "orcCore": "org.apache.orc:orc-core:1.6.3:nohive",
     "orcTools":"org.apache.orc:orc-tools:1.6.3",
-    'parquet': 'org.apache.parquet:parquet-hadoop:1.11.1',
-    'parquetAvro': 'org.apache.parquet:parquet-avro:1.11.1',
-    'parquetProto': 'org.apache.parquet:parquet-protobuf:1.11.1',
-    'parquetHadoop': 'org.apache.parquet:parquet-hadoop-bundle:1.11.1',
+    'parquet': 'org.apache.parquet:parquet-hadoop:1.11.0',
+    'parquetAvro': 'org.apache.parquet:parquet-avro:1.11.0',
+    'parquetProto': 'org.apache.parquet:parquet-protobuf:1.11.0',
+    'parquetHadoop': 'org.apache.parquet:parquet-hadoop-bundle:1.11.0',
     'reactivex': 'io.reactivex.rxjava2:rxjava:2.1.0',
     "slf4j": [
         "org.slf4j:slf4j-api:" + slf4jVersion,