You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/27 20:56:56 UTC
[GitHub] [camel-website] Gunkev opened a new pull request #280: changes on
footer
Gunkev opened a new pull request #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280
In this PR
![old-footer](https://user-images.githubusercontent.com/36812576/77799711-a4683a00-7075-11ea-9dc2-3659d8b5c8f4.png)
# Changes
![footer](https://user-images.githubusercontent.com/36812576/77799733-b649dd00-7075-11ea-8630-93a9bdb4137f.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#280: changes on footer
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#discussion_r401461660
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -52,6 +52,12 @@ footer .footer dl dt {
margin-bottom: 0.5rem;
}
+.stroke {
Review comment:
Can we scope this to footer?
```suggestion
footer .footer .stroke {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on a change in pull request #280:
changes on footer
Posted by GitBox <gi...@apache.org>.
Gunkev commented on a change in pull request #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#discussion_r401520865
##########
File path: antora-ui-camel/src/css/footer.css
##########
@@ -52,6 +52,12 @@ footer .footer dl dt {
margin-bottom: 0.5rem;
}
+.stroke {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] AemieJ commented on issue #280: changes on footer
Posted by GitBox <gi...@apache.org>.
AemieJ commented on issue #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#issuecomment-605394650
I really prefer the previous footer, it looks minimal and goes with the website design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #280: changes on footer
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #280: changes on footer
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#issuecomment-605404288
Agreed with @AemieJ
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on issue #280: changes on footer
Posted by GitBox <gi...@apache.org>.
Gunkev commented on issue #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#issuecomment-606682678
# Changes
![Screenshot from 2020-03-31 17-00-51](https://user-images.githubusercontent.com/36812576/78041566-c4934400-7368-11ea-927f-4a19272bd498.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #280: changes on footer
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#issuecomment-607281404
For future reference please run the checks `yarn checks` this broke the website build and needed to be reworked in d8909b7f24bc49f5f9e9f94ed2d2d3a9d42f5ddf.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Gunkev commented on issue #280: changes on footer
Posted by GitBox <gi...@apache.org>.
Gunkev commented on issue #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#issuecomment-607690846
> For future reference please run the checks `yarn checks` this broke the website build and needed to be reworked in [d8909b7](https://github.com/apache/camel-website/commit/d8909b7f24bc49f5f9e9f94ed2d2d3a9d42f5ddf).
Understood @zregvart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #280: changes on footer
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #280: changes on footer
URL: https://github.com/apache/camel-website/pull/280#issuecomment-607245933
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services