[jira] [Commented] (OAK-3907) Sync the files to directory upon copy from remote

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112111#comment-15112111 ] 

Thomas Mueller commented on OAK-3907:
-------------------------------------

I don't think using sync is needed, and using sync might slow down all other operations quite a lot (including the persistent cache and other file system operations).

How do we copy files (from remote to local)? Do we create the file, and then just copy data over block by block? Then even sync would not help if the process is killed during the copy operation (before the potential sync call).

What would help is to create the file first using a different name (.inProgress), and only once copying is done rename the file. 

Do we verify the file size of the local file matches the file size of the remote file before reading from the local file?

> Sync the files to directory upon copy from remote
> -------------------------------------------------
>
>                 Key: OAK-3907
>                 URL: https://issues.apache.org/jira/browse/OAK-3907
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.4, 1.2.11, 1.0.27
>
>
> {{IndexCopier}} does not {{sync}} the file to file system once files are copied from remote. This might cause problem on setup where local index file directory is on some SAN.
> For safety we should also sync the files upon copy from remote



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)