You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2002/03/14 19:54:01 UTC
Re: svn commit: rev 1511 - trunk/subversion/include trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/libsvn_ra_dav
On Thu, Mar 14, 2002 at 12:29:02PM -0600, cmpilato@tigris.org wrote:
>...
> +++ trunk/subversion/include/svn_ra.h Thu Mar 14 12:29:00 2002
>...
> @@ -233,22 +228,15 @@
> void *callback_baton,
> apr_pool_t *pool);
>
> - /* Retrieve a "working copy" property for an item relative to the
> - "root" of the session (defined by REPOS_URL to the open() vtable
> - function call).
> -
> - The baton passed to the get_wcprop callback is the CALLBACK_BATON.
> -
> - If it quite legal to set this field to NULL if the RA user cannot
> - support WC properties, or they are not defined/applicable for the
> - current session.
> -
> - ### we might have a problem if the RA layer ever wants a property
> - ### that corresponds to a different revision of the file than
> - ### what is in the WC. we'll cross that bridge one day...
> - */
> + /* Fetch working copy properties. */
> svn_ra_get_wc_prop_func_t get_wc_prop;
Woah! Why did you torch this comment? That removed all knowledge about
being legal to set that field to NULL.
I can see the info about "relative" and the baton is redundant with info
about the type (although the svn_ra_get_wc_prop_func_t doc needs to be
updated to remove refs to CLOSE_BATON).
This also removed the warning about retrieving props for a revision that
doesn't occur in the WC.
[ /me thinks of blowing away Ben's comment a couple weeks ago, too... ]
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1511 - trunk/subversion/include trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/libsvn_ra_dav
Posted by cm...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> > - /* Retrieve a "working copy" property for an item relative to the
> > - "root" of the session (defined by REPOS_URL to the open() vtable
> > - function call).
> > -
> > - The baton passed to the get_wcprop callback is the CALLBACK_BATON.
> > -
> > - If it quite legal to set this field to NULL if the RA user cannot
> > - support WC properties, or they are not defined/applicable for the
> > - current session.
> > -
> > - ### we might have a problem if the RA layer ever wants a property
> > - ### that corresponds to a different revision of the file than
> > - ### what is in the WC. we'll cross that bridge one day...
> > - */
> > + /* Fetch working copy properties. */
> > svn_ra_get_wc_prop_func_t get_wc_prop;
>
> Woah! Why did you torch this comment? That removed all knowledge about
> being legal to set that field to NULL.
Actually, I should have made a blanket comment in that callback baton
that states that it's okay to have get_wc_prop, set_wc_prop, or
close_commit set to NULL. Good catch.
> This also removed the warning about retrieving props for a revision that
> doesn't occur in the WC.
I thought I simply moved that comment elsewhere. I'll re-check, and
if not, will re-add.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org