You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/15 08:20:47 UTC

[GitHub] [skywalking-banyandb] wu-sheng commented on a change in pull request #34: Move proto files to proper packages

wu-sheng commented on a change in pull request #34:
URL: https://github.com/apache/skywalking-banyandb/pull/34#discussion_r689051356



##########
File path: api/proto/banyandb/database/v1/schema.proto
##########
@@ -44,10 +44,11 @@ message Duration {
 }
 
 enum FieldType {
-    FIELD_TYPE_STRING = 0;
-    FIELD_TYPE_INT = 1;
-    FIELD_TYPE_STRING_ARRAY = 2;
-    FIELD_TYPE_INT_ARRAY = 3;
+    FIELD_TYPE_UNSPECIFIED=0;

Review comment:
       This would break the client side. Notice, only add new index is healthy. So, please update the client side proto, and rebuild.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org